Bug Fix: List Too Small When Sharing Tab Only

chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h"
 
 #include "base/callback.h"
 #include "chrome/browser/media/webrtc/desktop_media_list.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 151 matching lines @@
         0);                                    // focus_rectangle_inset
 
     views::ScrollView* tab_scroll_view =
         views::ScrollView::CreateScrollViewWithBorder();
     base::string16 tab_title_text =
         l10n_util::GetStringUTF16(IDS_DESKTOP_MEDIA_PICKER_SOURCE_TYPE_TAB);
     list_views_.push_back(new DesktopMediaListView(
         this, std::move(tab_list), kTabStyle, kTabStyle, tab_title_text));
 
     tab_scroll_view->SetContents(list_views_.back());
-    tab_scroll_view->ClipHeightTo(kTabStyle.item_size.height(),
-                                  kTabStyle.item_size.height() * 2);
+    tab_scroll_view->ClipHeightTo(kTabStyle.item_size.height() * 7,

[msw, 2017/03/01 19:00:03]

Can you post some screenshots of before and after? What happens when the
dialog's minimum height (now 7 times the old minimum height) exceeds the
available height of the browser window? Should the minimum be left alone, but
the maximum increased?

[qiangchen, 2017/03/01 20:59:42]

Reduce it to 5. As 5 * tab height is almost 1 * window height.

Attached screenshot on crbug

[msw, 2017/03/01 23:26:48]

nit: I still think it might be better to use just one tab height for the
minimum. That way the dialog will still shrink the tab selection area to show
the Cancel/Share buttons, even when the parent chrome window is *super* short.
Otherwise, what's the point of showing 5 tabs if you can't click Share? (please
test out super short chrome windows and lmk what you think).

[qiangchen, 2017/03/03 16:39:32]

Done.

+                                  kTabStyle.item_size.height() * 10);
     tab_scroll_view->set_hide_horizontal_scrollbar(true);
     tab_scroll_view->set_background(
         views::Background::CreateSolidBackground(bg_color));
 
     pane_->AddTab(tab_title_text, tab_scroll_view);
     pane_->set_listener(this);
   }
 
   if (app_name == target_name) {
     description_label_->SetText(
@@ skipping 260 matching lines @@
   // DesktopMediaPicker.
   content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
                                    base::Bind(callback_, source));
   callback_.Reset();
 }
 
 // static
 std::unique_ptr<DesktopMediaPicker> DesktopMediaPicker::Create() {
   return std::unique_ptr<DesktopMediaPicker>(new DesktopMediaPickerViews());
 }