Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2725803004: Add SpdyFramerTests for existing ALTSVC handling functionality. (Closed)

Created:
3 years, 9 months ago by Bence
Modified:
3 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SpdyFramerTests for existing ALTSVC handling functionality. Add test for currently existing functionality (where "currently" means since https://crrev.com/2723203002 landed earlier today): * ALTSVC frames with empty or non-empty origins on stream zero or other streams are processed by the framer. Even though RFC7838 requires that these frames are ignored, this is done in a different layer. * On the other hand, ALTSVC frames with invalid Alt-Svc-Field-Value result in an error. These tests are parametrized, and are run both using SpdyFramer (the old frame decoder) and Http2FrameDecoder (the new frame decoder). This ensures that behavior of the two decoders is consistent. This CL lands server change 148902601 by bnc. BUG=488484, 696653 Review-Url: https://codereview.chromium.org/2725803004 Cr-Commit-Position: refs/heads/master@{#454138} Committed: https://chromium.googlesource.com/chromium/src/+/9b550534ae5ce2e122e3a96086cd995070deddc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M net/spdy/spdy_framer_test.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Bence
Ryan: PTAL. Thank you.
3 years, 9 months ago (2017-03-02 01:16:06 UTC) #6
Ryan Hamilton
lgtm
3 years, 9 months ago (2017-03-02 01:19:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725803004/1
3 years, 9 months ago (2017-03-02 01:27:37 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 01:39:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b550534ae5ce2e122e3a96086cd...

Powered by Google App Engine
This is Rietveld 408576698