Introduce PositionIteratorTest in webkit_unit_tests

Introduce PositionIteratorTest in webkit_unit_tests

This patch introduces |PositionIteratorTest| to record current behavior to catch
regression for improve code health.

This patch is also for preparation of patch[1].

Note: |PositionIteratorTest| needs to have more test cases. This patch
introduces test cases for patch[1].

[1] http://crrev.com/2720593005: Make PositionIterator to skip contents of
INPUT/SELECT/TEXTAREA

BUG=695317
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2725803002
Cr-Commit-Position: refs/heads/master@{#453893}
Committed: https://chromium.googlesource.com/chromium/src/+/ff3ad9a544321a740a585329d624ad78b4c6c551

[yosin_UTC9, 2017-03-01 05:23:19]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 05:23:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-01 05:27:11]

Description was changed from

==========
2017-03-01T14:22:10

2017-03-01T14:19:36

BUG=
==========

to

==========
Introduce PositionIteratorTest in webkit_unit_tests

This patch introduces |PositionIteratorTest| to record current behavior to catch
regression for improve code health.

This patch is also for preparation of patch[1].

[1] http://crrev.com/2720593005: Make PositionIterator to skip contents of
INPUT/SELECT/TEXTAREA

BUG=695317
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-01 05:28:30]

Description was changed from

==========
Introduce PositionIteratorTest in webkit_unit_tests

This patch introduces |PositionIteratorTest| to record current behavior to catch
regression for improve code health.

This patch is also for preparation of patch[1].

[1] http://crrev.com/2720593005: Make PositionIterator to skip contents of
INPUT/SELECT/TEXTAREA

BUG=695317
TEST=n/a; no behavior changes
==========

to

==========
Introduce PositionIteratorTest in webkit_unit_tests

This patch introduces |PositionIteratorTest| to record current behavior to catch
regression for improve code health.

This patch is also for preparation of patch[1].

Note: |PositionIteratorTest| needs to have more test cases. This patch
introduces test cases for patch[1].

[1] http://crrev.com/2720593005: Make PositionIterator to skip contents of
INPUT/SELECT/TEXTAREA

BUG=695317
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-01 05:48:45]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-01 05:48:46]

PTAL

[tkent, 2017-03-01 06:03:13]

lgtm

[yoichio, 2017-03-01 06:08:50]

lgtm with nit

https://codereview.chromium.org/2725803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp (right):

https://codereview.chromium.org/2725803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp:22:
PositionIterator domIterator(Position::lastPositionInNode(document().body()));
Could you add 
EXPECT_EQ(Position::lastPositionInNode(document().body()), 
 domiterator.computePOsition())?

[yosin_UTC9, 2017-03-01 06:41:05]

Thanks for reviewing!
Committing...

https://codereview.chromium.org/2725803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp (right):

https://codereview.chromium.org/2725803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp:22:
PositionIterator domIterator(Position::lastPositionInNode(document().body()));
On 2017/03/01 at 06:08:49, yoichio wrote:
> Could you add 
> EXPECT_EQ(Position::lastPositionInNode(document().body()), 
>  domiterator.computePOsition())?

Done.

[yosin_UTC9, 2017-03-01 06:41:08]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-01 06:41:08]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/2725803002/#ps20001
(title: "2017-03-01T15:38:19 Add EXPECT_EQ() just after ctor by yoichio@'s
comment")

[commit-bot: I haz the power, 2017-03-01 06:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 09:23:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488350468102890,
"parent_rev": "571710acd59dffe9e5fd6fab998282901cd6dcb1", "commit_rev":
"ff3ad9a544321a740a585329d624ad78b4c6c551"}

[commit-bot: I haz the power, 2017-03-01 09:24:36]

Description was changed from

==========
Introduce PositionIteratorTest in webkit_unit_tests

This patch introduces |PositionIteratorTest| to record current behavior to catch
regression for improve code health.

This patch is also for preparation of patch[1].

Note: |PositionIteratorTest| needs to have more test cases. This patch
introduces test cases for patch[1].

[1] http://crrev.com/2720593005: Make PositionIterator to skip contents of
INPUT/SELECT/TEXTAREA

BUG=695317
TEST=n/a; no behavior changes
==========

to

==========
Introduce PositionIteratorTest in webkit_unit_tests

This patch introduces |PositionIteratorTest| to record current behavior to catch
regression for improve code health.

This patch is also for preparation of patch[1].

Note: |PositionIteratorTest| needs to have more test cases. This patch
introduces test cases for patch[1].

[1] http://crrev.com/2720593005: Make PositionIterator to skip contents of
INPUT/SELECT/TEXTAREA

BUG=695317
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2725803002
Cr-Commit-Position: refs/heads/master@{#453893}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff3ad9a544321a740a585329d624...
==========

[commit-bot: I haz the power, 2017-03-01 09:24:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ff3ad9a544321a740a585329d624...