Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2725783006: Grit: Reserve 30 resource IDs for includes in chrome/browser/browser_resources.grd (Closed)

Created:
3 years, 9 months ago by tsergeant
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Grit: Reserve 30 resource IDs for includes in chrome/browser/browser_resources.grd BUG=697706 Review-Url: https://codereview.chromium.org/2725783006 Cr-Commit-Position: refs/heads/master@{#454397} Committed: https://chromium.googlesource.com/chromium/src/+/d39f556a09046fb8fd2c11f7c5b9d6b821c5e9ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M tools/gritsettings/resource_ids View 1 chunk +17 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
tsergeant
PTAL. We ran into the current limit while implementing some upcoming changes to the MD ...
3 years, 9 months ago (2017-03-02 04:54:19 UTC) #7
Nico
lgtm
3 years, 9 months ago (2017-03-02 14:32:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725783006/20001
3 years, 9 months ago (2017-03-02 22:00:11 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:09:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d39f556a09046fb8fd2c11f7c5b9...

Powered by Google App Engine
This is Rietveld 408576698