Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2725773002: Remove NGBlockNode constructor, SetFirstChild, SetNextSibling methods (Closed)
Patch Set: CR fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
index 5a1abf690a32b83b879a9620ae4030864001183c..4dd83d610792bcc3946dceef06c3eb2cde5d16d5 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
@@ -103,6 +103,9 @@ NGConstraintSpace* NGConstraintSpace::CreateFromLayoutObject(
NGPhysicalSize initial_containing_block_size{
LayoutUnit(icb_float_size.width()), LayoutUnit(icb_float_size.height())};
+ DCHECK(initial_containing_block_size.width >= LayoutUnit());
Gleb Lanbin 2017/03/01 21:08:42 1) DCHECK(initial_containing_block_size >= NGPhysi
dgrogan 2017/03/01 21:25:09 nit: DCHECK_GE?
atotic 2017/03/01 23:07:49 done.
+ DCHECK(initial_containing_block_size.height >= LayoutUnit());
+
return NGConstraintSpaceBuilder(writing_mode)
.SetAvailableSize(available_size)
.SetPercentageResolutionSize(percentage_size)

Powered by Google App Engine
This is Rietveld 408576698