Remove NGBlockNode constructor, SetFirstChild, SetNextSibling methods

third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_constraint_space.h"
 
 #include "core/layout/LayoutBlock.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/ng/ng_constraint_space_builder.h"
 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
@@ skipping 85 matching lines @@
     fixed_block = true;
   }
 
   bool is_new_fc =
       box.isLayoutBlock() && toLayoutBlock(box).createsNewFormattingContext();
 
   FloatSize icb_float_size = box.view()->viewportSizeForViewportUnits();
   NGPhysicalSize initial_containing_block_size{
       LayoutUnit(icb_float_size.width()), LayoutUnit(icb_float_size.height())};
 
+  DCHECK(initial_containing_block_size.width >= LayoutUnit());

[Gleb Lanbin, 2017/03/01 21:08:42]

1) DCHECK(initial_containing_block_size >= NGPhysicalSize())
   >> "ICB cannot be zero-sized by the spec.";
2) add operator >= to NGPhysicalSize

[dgrogan, 2017/03/01 21:25:09]

nit: DCHECK_GE?

[atotic, 2017/03/01 23:07:49]

done.
no, would run into conflicts, ng_units refactor is in flight.
done

+  DCHECK(initial_containing_block_size.height >= LayoutUnit());
+
   return NGConstraintSpaceBuilder(writing_mode)
       .SetAvailableSize(available_size)
       .SetPercentageResolutionSize(percentage_size)
       .SetInitialContainingBlockSize(initial_containing_block_size)
       .SetIsInlineDirectionTriggersScrollbar(
           box.styleRef().overflowInlineDirection() == EOverflow::kAuto)
       .SetIsBlockDirectionTriggersScrollbar(
           box.styleRef().overflowBlockDirection() == EOverflow::kAuto)
       .SetIsFixedSizeInline(fixed_inline)
       .SetIsFixedSizeBlock(fixed_block)
@@ skipping 24 matching lines @@
       bfc_offset_.block_offset.toString().ascii().data(),
       AvailableSize().inline_size.toString().ascii().data(),
       AvailableSize().block_size.toString().ascii().data(),
       margin_strut_.ToString().ascii().data(),
       clearance_offset_.has_value()
           ? clearance_offset_.value().toString().ascii().data()
           : "none");
 }
 
 }  // namespace blink