Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2725763003:
DelegatedFrameHostAndroid should use CompositorFrameSinkSupport (Closed)
|
Created:
3 years, 9 months ago by Saman Sami Modified:
3 years, 9 months ago CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su Project:
chromium Visibility:
Public. |
DescriptionDelegatedFrameHostAndroid should use CompositorFrameSinkSupport
This helps us unify the API to display compositor and enable SurfaceReferences.
BUG=693902, 691684
Review-Url: https://codereview.chromium.org/2725763003
Cr-Commit-Position: refs/heads/master@{#454401}
Committed: https://chromium.googlesource.com/chromium/src/+/b779ecab5440706c5b1b7f3c8356ba110c535e97
Patch Set 1 #Patch Set 2 : c #Patch Set 3 : c #Patch Set 4 : c #Patch Set 5 : c #Patch Set 6 : c #Patch Set 7 : c #Patch Set 8 : c #Patch Set 9 : c #Patch Set 10 : c #
Messages
Total messages: 40 (35 generated)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== DelegatedFrameHostAndroid should use CompositorFrameSinkSupport BUG=693902,691684 ========== to ========== DelegatedFrameHostAndroid should use CompositorFrameSinkSupport This helps us unify the API to display compositor and enable SurfaceReferences. BUG=693902,691684 ==========
samans@chromium.org changed reviewers: + boliu@chromium.org, fsamuel@chromium.org
PTAL
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by samans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 180001, "attempt_start_ts": 1488492632303950,
"parent_rev": "d9bbb44814c924c58e80bb0e8b64a9a634fd2198", "commit_rev":
"b779ecab5440706c5b1b7f3c8356ba110c535e97"}
Message was sent while issue was closed.
Description was changed from ========== DelegatedFrameHostAndroid should use CompositorFrameSinkSupport This helps us unify the API to display compositor and enable SurfaceReferences. BUG=693902,691684 ========== to ========== DelegatedFrameHostAndroid should use CompositorFrameSinkSupport This helps us unify the API to display compositor and enable SurfaceReferences. BUG=693902,691684 Review-Url: https://codereview.chromium.org/2725763003 Cr-Commit-Position: refs/heads/master@{#454401} Committed: https://chromium.googlesource.com/chromium/src/+/b779ecab5440706c5b1b7f3c8356... ==========
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as https://chromium.googlesource.com/chromium/src/+/b779ecab5440706c5b1b7f3c8356... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
