Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2725723002: Purge new localstorage memory cache when under memory pressure. (Closed)

Created:
3 years, 9 months ago by Marijn Kruisselbrink
Modified:
3 years, 9 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Purge new localstorage memory cache when under memory pressure. This makes sure that the new localstorage implementation purges caches under the same circumstances as the old implementation. BUG=586194 Review-Url: https://codereview.chromium.org/2725723002 Cr-Commit-Position: refs/heads/master@{#453967} Committed: https://chromium.googlesource.com/chromium/src/+/dea811df1cec4cbfd0502821c8a2e1e6da6bfe32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/leveldb_wrapper_impl_unittest.cc View 4 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Marijn Kruisselbrink
3 years, 9 months ago (2017-02-28 22:27:55 UTC) #4
jam
lgtm
3 years, 9 months ago (2017-03-01 15:51:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725723002/1
3 years, 9 months ago (2017-03-01 17:53:13 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 17:58:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dea811df1cec4cbfd0502821c8a2...

Powered by Google App Engine
This is Rietveld 408576698