Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2725713002:
Use O_CLOEXEC when calling open() in rand_util_posix (Closed)
|
Created:
3 years, 9 months ago by Mark Mentovai Modified:
3 years, 9 months ago Reviewers:
scottmg CC:
chromium-reviews, vmpstr+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse O_CLOEXEC when calling open() in rand_util_posix
BUG=688362
Review-Url: https://codereview.chromium.org/2725713002
Cr-Commit-Position: refs/heads/master@{#453754}
Committed: https://chromium.googlesource.com/chromium/src/+/4cec49482d07386181836bfd950a06445421471d
Patch Set 1 #Patch Set 2 : No O_NOCTTY (so O_CTTY?)—some Linuces don’t have it?! #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by mark@chromium.org to run a CQ dry run
Description was changed from ========== Use O_CLOEXEC (and O_NOCTTY) when calling open() BUG=688362 ========== to ========== Use O_CLOEXEC (and O_NOCTTY) when calling open() in rand_util BUG=688362 ==========
mark@chromium.org changed reviewers: + scottmg@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by mark@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Looks like CrOS and Linux aren't happy about O_NOCTTY, but lgtm once they are.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Use O_CLOEXEC (and O_NOCTTY) when calling open() in rand_util BUG=688362 ========== to ========== Use O_CLOEXEC when calling open() in rand_util_posix BUG=688362 ==========
Description was changed from ========== Use O_CLOEXEC when calling open() in rand_util_posix BUG=688362 ========== to ========== Use O_CLOEXEC when calling open() in rand_util_posix BUG=688362 ==========
Yeah, some Linuces seem to not define O_NOCTTY. Some oddball libc must omit it from its <fcntl.h>. Going ahead without.
The CQ bit was checked by mark@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2725713002/#ps20001 (title: "No O_NOCTTY (so O_CTTY?)—some Linuces don’t have it?!")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488321087816470,
"parent_rev": "f67c3f27ee912093f7110cb33f33ff7f1a144371", "commit_rev":
"4cec49482d07386181836bfd950a06445421471d"}
Message was sent while issue was closed.
Description was changed from ========== Use O_CLOEXEC when calling open() in rand_util_posix BUG=688362 ========== to ========== Use O_CLOEXEC when calling open() in rand_util_posix BUG=688362 Review-Url: https://codereview.chromium.org/2725713002 Cr-Commit-Position: refs/heads/master@{#453754} Committed: https://chromium.googlesource.com/chromium/src/+/4cec49482d07386181836bfd950a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4cec49482d07386181836bfd950a... |
