third_party/WebKit/Source/bindings/templates/union_container.h.tmpl - Issue 2725673002: WIP bindings: Expand usage of NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/union_container.h.tmpl

Issue 2725673002: WIP bindings: Expand usage of NativeValueTraits. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl ('k') | third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/union_container.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/union_container.h.tmpl b/third_party/WebKit/Source/bindings/templates/union_container.h.tmpl

index fd29d46cc6c32b1f25784fafab5da84d7a94faac..39ad7e0d94a51044639a6750df36eeda0658dc1d 100644

--- a/third_party/WebKit/Source/bindings/templates/union_container.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/union_container.h.tmpl

@@ -67,9 +67,15 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& im

template <>

struct NativeValueTraits<{{cpp_class}}> {

+ using ImplType = {{cpp_class}};

{{exported}}static {{cpp_class}} nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

};

+template <>

+struct V8TypeOf<{{cpp_class}}> {

+ typedef {{v8_class}} Type;

+};

} // namespace blink

// We need to set canInitializeWithMemset=true because HeapVector supports