third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl - Issue 2725673002: WIP bindings: Expand usage of NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

Issue 2725673002: WIP bindings: Expand usage of NativeValueTraits. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/templates/union_container.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

index ac99c69cd21e220fd2fcfd6f84f80fe36bf5df0d..0955055c16c9e0cbf24cfde659b58a16dc5b443c 100644

--- a/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

@@ -198,7 +198,7 @@ v8::Local<v8::Value> ToV8(const {{cpp_class}}& impl, v8::Local<v8::Object> creat

{{cpp_class}} NativeValueTraits<{{cpp_class}}>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) {

{{cpp_class}} impl;

- {{v8_class}}::toImpl(isolate, value, impl, UnionTypeConversionMode::NotNullable, exceptionState);

+ {{v8_class}}::toImpl(isolate, value, impl, UnionTypeConversionMode::{% if includes_nullable_type %}Nullable{% else %}NotNullable{% endif %}, exceptionState);

return impl;

}