Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2725613002: Fix unused lambda captures for big endian targets. (Closed)

Created:
3 years, 9 months ago by Ilija.Pavlovic1
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix unused lambda captures for big endian targets. This CL fixes unused lambda captures for big endian targets when Clang is used for build V8. TEST= BUG= Review-Url: https://codereview.chromium.org/2725613002 Cr-Commit-Position: refs/heads/master@{#43511} Committed: https://chromium.googlesource.com/v8/v8/+/d0e1de1705993efa508d3dff238fafa9fc078ae0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/unittests/value-serializer-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ilija.Pavlovic1
PTAL
3 years, 9 months ago (2017-02-28 12:25:48 UTC) #2
Ilija.Pavlovic1
PTAL
3 years, 9 months ago (2017-03-01 06:28:49 UTC) #4
Jakob Kummerow
lgtm
3 years, 9 months ago (2017-03-01 10:46:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725613002/1
3 years, 9 months ago (2017-03-01 11:55:15 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 12:16:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d0e1de1705993efa508d3dff238fafa9fc0...

Powered by Google App Engine
This is Rietveld 408576698