Construct URLSearchParams from sequence initializer.

Construct URLSearchParams from sequence initializer.

Follow up recent spec addition[1,2] and support sequence<sequence<USVString>>
initializers for URLSearchParams.

1 - https://github.com/whatwg/url/issues/27
2 - https://github.com/whatwg/url/pull/175

R=tyoshino,haraken
BUG=680531
Review-Url: https://codereview.chromium.org/2725593003
Cr-Commit-Position: refs/heads/master@{#453903}
Committed: https://chromium.googlesource.com/chromium/src/+/4c9507d55e235b96d792dd0244f0ef41e470a5f1

[sof, 2017-02-28 19:11:29]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 19:12:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-02-28 20:29:15]

sigbjornf@opera.com changed reviewers:
+ mkwst@chromium.org, tyoshino@chromium.org

[sof, 2017-02-28 20:29:15]

please take a look.

(importing wpt/url is something we should get around to.. )

[commit-bot: I haz the power, 2017-02-28 21:19:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 21:19:25]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2017-03-01 08:07:26]

Can you include
- https://github.com/whatwg/url/issues/27
- https://github.com/whatwg/url/pull/175
in the CL description?

https://codereview.chromium.org/2725593003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/domurl/urlsearchparams-constructor.html
(right):

https://codereview.chromium.org/2725593003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/domurl/urlsearchparams-constructor.html:173:
assert_true(params !== null, '1=2&a=b');
can we also compare params.toString() with ""?

the description looks c&p-ed from L176. should be e.g. "Empty sequence".

https://codereview.chromium.org/2725593003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/URLSearchParams.cpp (right):

https://codereview.chromium.org/2725593003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/URLSearchParams.cpp:75:
instance->append(pair[0], pair[1]);
can we populate m_params first and then runUpdateSteps() once at the end like
setInput()? this would call runUpdateSteps() every time append() is called.

[sof, 2017-03-01 08:29:57]

Description was changed from

==========
Construct URLSearchParams from sequence initializer.

Follow up recent spec addition and support sequence<sequence<USVString>>
initializers for URLSearchParams.

R=
BUG=680531
==========

to

==========
Construct URLSearchParams from sequence initializer.

Follow up recent spec addition[1,2] and support sequence<sequence<USVString>>
initializers for URLSearchParams.

1 - https://github.com/whatwg/url/issues/27
2 - https://github.com/whatwg/url/pull/175

R=
BUG=680531
==========

[sof, 2017-03-01 08:40:59]

thanks for the quick review.

https://codereview.chromium.org/2725593003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/domurl/urlsearchparams-constructor.html
(right):

https://codereview.chromium.org/2725593003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/domurl/urlsearchparams-constructor.html:173:
assert_true(params !== null, '1=2&a=b');
On 2017/03/01 08:07:26, tyoshino wrote:
> can we also compare params.toString() with ""?
> 
> the description looks c&p-ed from L176. should be e.g. "Empty sequence".

oops, guilty :) updated.

https://codereview.chromium.org/2725593003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/URLSearchParams.cpp (right):

https://codereview.chromium.org/2725593003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/URLSearchParams.cpp:75:
instance->append(pair[0], pair[1]);
On 2017/03/01 08:07:26, tyoshino wrote:
> can we populate m_params first and then runUpdateSteps() once at the end like
> setInput()? this would call runUpdateSteps() every time append() is called.

Done, runUpdateSteps() would be near no-op in this case.

[sof, 2017-03-01 08:41:05]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 08:41:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2017-03-01 08:57:06]

lgtm!

https://codereview.chromium.org/2725593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/URLSearchParams.cpp (right):

https://codereview.chromium.org/2725593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/URLSearchParams.cpp:79:
instance->runUpdateSteps();
optional: we can also early return before the for-loop.

[haraken, 2017-03-01 08:59:43]

modules owner LGTM

[sof, 2017-03-01 09:05:52]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 09:06:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-03-01 09:06:09]

https://codereview.chromium.org/2725593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/URLSearchParams.cpp (right):

https://codereview.chromium.org/2725593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/URLSearchParams.cpp:79:
instance->runUpdateSteps();
On 2017/03/01 08:57:06, tyoshino wrote:
> optional: we can also early return before the for-loop.

ok, consistent style to do so.

[tyoshino (SeeGerritForStatus), 2017-03-01 09:37:39]

lgtm again: ps3

let's

https://codereview.chromium.org/2725593003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/URLSearchParams.cpp (right):

https://codereview.chromium.org/2725593003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/URLSearchParams.cpp:52: // consider removing.
Filed 697378 for this!

[tyoshino (SeeGerritForStatus), 2017-03-01 09:38:05]

On 2017/03/01 09:37:39, tyoshino wrote:
> let's

Please never mind this!

[sof, 2017-03-01 10:28:13]

Description was changed from

==========
Construct URLSearchParams from sequence initializer.

Follow up recent spec addition[1,2] and support sequence<sequence<USVString>>
initializers for URLSearchParams.

1 - https://github.com/whatwg/url/issues/27
2 - https://github.com/whatwg/url/pull/175

R=
BUG=680531
==========

to

==========
Construct URLSearchParams from sequence initializer.

Follow up recent spec addition[1,2] and support sequence<sequence<USVString>>
initializers for URLSearchParams.

1 - https://github.com/whatwg/url/issues/27
2 - https://github.com/whatwg/url/pull/175

R=tyoshino,haraken
BUG=680531
==========

[commit-bot: I haz the power, 2017-03-01 11:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 11:00:55]

Dry run: This issue passed the CQ dry run.

[sof, 2017-03-01 11:01:08]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-03-01 11:01:09]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2725593003/#ps40001
(title: "style update")

[commit-bot: I haz the power, 2017-03-01 11:01:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 11:05:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488366068918790,
"parent_rev": "9d86f02c7bc5dd777badfb7c1e675a87e434e5d6", "commit_rev":
"4c9507d55e235b96d792dd0244f0ef41e470a5f1"}

[commit-bot: I haz the power, 2017-03-01 11:06:30]

Description was changed from

==========
Construct URLSearchParams from sequence initializer.

Follow up recent spec addition[1,2] and support sequence<sequence<USVString>>
initializers for URLSearchParams.

1 - https://github.com/whatwg/url/issues/27
2 - https://github.com/whatwg/url/pull/175

R=tyoshino,haraken
BUG=680531
==========

to

==========
Construct URLSearchParams from sequence initializer.

Follow up recent spec addition[1,2] and support sequence<sequence<USVString>>
initializers for URLSearchParams.

1 - https://github.com/whatwg/url/issues/27
2 - https://github.com/whatwg/url/pull/175

R=tyoshino,haraken
BUG=680531

Review-Url: https://codereview.chromium.org/2725593003
Cr-Commit-Position: refs/heads/master@{#453903}
Committed:
https://chromium.googlesource.com/chromium/src/+/4c9507d55e235b96d792dd0244f0...
==========

[commit-bot: I haz the power, 2017-03-01 11:06:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4c9507d55e235b96d792dd0244f0...