[regexp] fix /\W/ui wrt \u017f and \u212a.

[regexp] fix /\W/ui wrt \u017f and \u212a.

R=jgruber@chromium.org
BUG=v8:5080
Review-Url: https://codereview.chromium.org/2725583002
Cr-Commit-Position: refs/heads/master@{#43496}
Committed: https://chromium.googlesource.com/v8/v8/+/a813525a075271c0b787df2702006229a182cd72

[jgruber, 2017-02-28 13:44:57]

Nice! lgtm

https://codereview.chromium.org/2725583002/diff/1/src/regexp/jsregexp.cc
File src/regexp/jsregexp.cc (right):

https://codereview.chromium.org/2725583002/diff/1/src/regexp/jsregexp.cc#newc...
src/regexp/jsregexp.cc:5615: //         \B to (?<=\W)(?=\W)|(?<=\w)(?=\w)
Nit: Please swap the group order of \B to make the loop below easier to
understand (i == 0 in the first column, i == 1 in the second).

https://codereview.chromium.org/2725583002/diff/1/src/regexp/jsregexp.cc#newc...
src/regexp/jsregexp.cc:5661: return compiler->unicode() &&
compiler->ignore_case()
WDYT about adding compiler->needs_unicode_case_equivalents() (or similar) with
short documentation about what's going on?

https://codereview.chromium.org/2725583002/diff/1/src/regexp/regexp-ast.h
File src/regexp/regexp-ast.h (right):

https://codereview.chromium.org/2725583002/diff/1/src/regexp/regexp-ast.h#new...
src/regexp/regexp-ast.h:83: bool add_unicode_case_equivalents, Zone* zone);
What if we add an AddClassEscape overload that implements additional handling
for add_unicode_case_equivalents? That way we could avoid having to touch all
unrelated use sites.

[Yang, 2017-02-28 14:26:11]

https://codereview.chromium.org/2725583002/diff/1/src/regexp/jsregexp.cc
File src/regexp/jsregexp.cc (right):

https://codereview.chromium.org/2725583002/diff/1/src/regexp/jsregexp.cc#newc...
src/regexp/jsregexp.cc:5615: //         \B to (?<=\W)(?=\W)|(?<=\w)(?=\w)
On 2017/02/28 13:44:56, jgruber wrote:
> Nit: Please swap the group order of \B to make the loop below easier to
> understand (i == 0 in the first column, i == 1 in the second).

Done.

https://codereview.chromium.org/2725583002/diff/1/src/regexp/jsregexp.cc#newc...
src/regexp/jsregexp.cc:5661: return compiler->unicode() &&
compiler->ignore_case()
On 2017/02/28 13:44:56, jgruber wrote:
> WDYT about adding compiler->needs_unicode_case_equivalents() (or similar) with
> short documentation about what's going on?

Done.

https://codereview.chromium.org/2725583002/diff/1/src/regexp/regexp-ast.h
File src/regexp/regexp-ast.h (right):

https://codereview.chromium.org/2725583002/diff/1/src/regexp/regexp-ast.h#new...
src/regexp/regexp-ast.h:83: bool add_unicode_case_equivalents, Zone* zone);
On 2017/02/28 13:44:56, jgruber wrote:
> What if we add an AddClassEscape overload that implements additional handling
> for add_unicode_case_equivalents? That way we could avoid having to touch all
> unrelated use sites.

Done.

[Yang, 2017-02-28 18:02:57]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-28 18:02:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2725583002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2017-02-28 18:03:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 18:28:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488304977891200,
"parent_rev": "0db5bc23e9d875635c4a0f1eeea5f2b81876c46d", "commit_rev":
"a813525a075271c0b787df2702006229a182cd72"}

[commit-bot: I haz the power, 2017-02-28 18:28:49]

Description was changed from

==========
[regexp] fix /\W/ui wrt \u017f and \u212a.

R=jgruber@chromium.org
BUG=v8:5080
==========

to

==========
[regexp] fix /\W/ui wrt \u017f and \u212a.

R=jgruber@chromium.org
BUG=v8:5080

Review-Url: https://codereview.chromium.org/2725583002
Cr-Commit-Position: refs/heads/master@{#43496}
Committed:
https://chromium.googlesource.com/v8/v8/+/a813525a075271c0b787df2702006229a18...
==========

[commit-bot: I haz the power, 2017-02-28 18:28:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a813525a075271c0b787df2702006229a18...