Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2725543002: Add unprefixed -webkit-line-break as an alias to import csswg-test (Closed)

Created:
3 years, 9 months ago by kojii
Modified:
3 years, 9 months ago
Reviewers:
tkent, haraken
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unprefixed -webkit-line-break as an alias to import csswg-test This patch adds unprefixed line-break as an alias to -webkit-line-break. Currently, the -webkit-line-break is parsed but is not honored. This is a preparation step to import csswg-test for the 'line-break' property. To import csswg-test, adding unprefixed aliases is recommended in crbug.com/614955. BUG=306730, 614955 Review-Url: https://codereview.chromium.org/2725543002 Cr-Commit-Position: refs/heads/master@{#453559} Committed: https://chromium.googlesource.com/chromium/src/+/c90e37c93ed9855f9f2e2d7a1b8729c6db5b3934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
kojii
PTAL.
3 years, 9 months ago (2017-02-28 06:25:16 UTC) #6
tkent
lgtm. Do we have intent-to-implement for it? If not, I'd recommend to send it.
3 years, 9 months ago (2017-02-28 07:06:33 UTC) #9
kojii
haraken@, PTAL for tools/metrics/histograms/histograms.xml > Do we have intent-to-implement for it? If not, I'd recommend ...
3 years, 9 months ago (2017-02-28 07:14:26 UTC) #11
haraken
LGTM
3 years, 9 months ago (2017-02-28 07:18:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725543002/1
3 years, 9 months ago (2017-02-28 09:53:26 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 09:58:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c90e37c93ed9855f9f2e2d7a1b87...

Powered by Google App Engine
This is Rietveld 408576698