Move UrlInfoTest to junit

Move UrlInfoTest to junit

UrlInfoTest does not need to be an instrumentation test, so this change
moves it from javatests/ to junit/.

BUG=696804
Review-Url: https://codereview.chromium.org/2725523002
Cr-Commit-Position: refs/heads/master@{#453648}
Committed: https://chromium.googlesource.com/chromium/src/+/701a03d7ed45254fb5dba4f89c6fc7e990cadde5

[cco3, 2017-02-28 01:06:29]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2017-02-28 01:13:58]

lgtm

[cco3, 2017-02-28 01:15:36]

cco3@chromium.org changed reviewers:
+ jbudorick@chromium.org

[cco3, 2017-02-28 01:15:36]

Hi jbudorick@, I'm going to be moving several files from javatests/ to junit/. 
Would you be able to do these reviews?

[jbudorick, 2017-02-28 01:35:27]

this lgtm

On 2017/02/28 01:15:36, cco3 wrote:
> Hi jbudorick@, I'm going to be moving several files from javatests/ to junit/.

> Would you be able to do these reviews?

I'd be happy to, but beware that I'm not an OWNER in either
chrome/android/javatests/ or chrome/android/junit/.

[cco3, 2017-02-28 01:37:43]

On 2017/02/28 01:15:36, cco3 wrote:
> Hi jbudorick@, I'm going to be moving several files from javatests/ to junit/.

> Would you be able to do these reviews?

Ah rats.  Well thanks.

[cco3, 2017-02-28 01:37:44]

On 2017/02/28 01:15:36, cco3 wrote:
> Hi jbudorick@, I'm going to be moving several files from javatests/ to junit/.

> Would you be able to do these reviews?

Ah rats.  Well thanks.

[cco3, 2017-02-28 01:42:40]

cco3@chromium.org changed reviewers:
+ nyquist@chromium.org

[cco3, 2017-02-28 01:42:41]

Hi Tommy, I'm going to be moving over some of these tests to junit/.  Would you
be able to review?

[nyquist, 2017-02-28 07:06:36]

lgtm

https://codereview.chromium.org/2725523002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java
(right):

https://codereview.chromium.org/2725523002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java:50:
assertEquals(mReferenceUrlInfo.getDistance(), urlInfo.getDistance(), .001);
Nit: Could you extract .001 out to a constant "EPSILON"? It just makes it easier
to read the test.

[cco3, 2017-02-28 17:15:34]

https://codereview.chromium.org/2725523002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java
(right):

https://codereview.chromium.org/2725523002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlInfoTest.java:50:
assertEquals(mReferenceUrlInfo.getDistance(), urlInfo.getDistance(), .001);
On 2017/02/28 07:06:36, nyquist wrote:
> Nit: Could you extract .001 out to a constant "EPSILON"? It just makes it
easier
> to read the test.

Done.

[cco3, 2017-02-28 17:17:59]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-02-28 17:18:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, jbudorick@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2725523002/#ps20001
(title: "Move UrlInfoTest to junit")

[commit-bot: I haz the power, 2017-02-28 17:18:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 18:37:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488302279233150,
"parent_rev": "8af45a18bab6cf4f1dc16a92a229dfa2b7e81dd1", "commit_rev":
"701a03d7ed45254fb5dba4f89c6fc7e990cadde5"}

[commit-bot: I haz the power, 2017-02-28 18:38:30]

Description was changed from

==========
Move UrlInfoTest to junit

UrlInfoTest does not need to be an instrumentation test, so this change
moves it from javatests/ to junit/.

BUG=696804
==========

to

==========
Move UrlInfoTest to junit

UrlInfoTest does not need to be an instrumentation test, so this change
moves it from javatests/ to junit/.

BUG=696804

Review-Url: https://codereview.chromium.org/2725523002
Cr-Commit-Position: refs/heads/master@{#453648}
Committed:
https://chromium.googlesource.com/chromium/src/+/701a03d7ed45254fb5dba4f89c6f...
==========

[commit-bot: I haz the power, 2017-02-28 18:38:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/701a03d7ed45254fb5dba4f89c6f...