Issue 27255: Linux: first part of removing GTK from the renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27255: Linux: first part of removing GTK from the renderer (Closed)

Created:
11 years, 10 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: first part of removing GTK from the renderer This patch adds the resources which the WebKit changes need. This shouldn't change anything.

Patch Set 2 : Use if statement #

Total comments: 2

Patch Set 3 : switch to WebKit style names for resources #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, --3 lines)			Patch
M	chrome/app/chrome_resources.scons	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/chromium_bridge_impl.cc	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
A	webkit/glue/resources/linux-checkbox-off.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/glue/resources/linux-checkbox-on.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/glue/resources/linux-radio-off.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/glue/resources/linux-radio-on.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/glue/webkit_resources.grd	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/27255/diff/1001/2002 File webkit/glue/chromium_bridge_impl.cc (right): http://codereview.chromium.org/27255/diff/1001/2002#newcode276 Line 276: } else if (!strcmp(name, "linux-checkbox-off")) { Nit: ...

11 years, 10 months ago (2009-02-27 01:52:55 UTC) #2

agl

11 years, 10 months ago (2009-02-27 01:57:34 UTC) #3

http://codereview.chromium.org/27255/diff/1001/2002
File webkit/glue/chromium_bridge_impl.cc (right):

http://codereview.chromium.org/27255/diff/1001/2002#newcode276
Line 276: } else if (!strcmp(name, "linux-checkbox-off")) {
On 2009/02/27 01:52:55, tony wrote:
> Nit: We should probably be consistent with the other webkit resources and name
> these linuxCheckboOff, etc.

Done.