Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 27255: Linux: first part of removing GTK from the renderer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by agl
Modified:
5 years, 9 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: first part of removing GTK from the renderer This patch adds the resources which the WebKit changes need. This shouldn't change anything.

Patch Set 1 #

Patch Set 2 : Use if statement #

Total comments: 2

Patch Set 3 : switch to WebKit style names for resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, --3 lines) Patch
M chrome/app/chrome_resources.scons View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/chromium_bridge_impl.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A webkit/glue/resources/linux-checkbox-off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/linux-checkbox-on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/linux-radio-off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/glue/resources/linux-radio-on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/webkit_resources.grd View 1 2 chunks +7 lines, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)
agl
8 years ago (2009-02-27 01:47:18 UTC) #1
tony
LGTM http://codereview.chromium.org/27255/diff/1001/2002 File webkit/glue/chromium_bridge_impl.cc (right): http://codereview.chromium.org/27255/diff/1001/2002#newcode276 Line 276: } else if (!strcmp(name, "linux-checkbox-off")) { Nit: ...
8 years ago (2009-02-27 01:52:55 UTC) #2
agl
8 years ago (2009-02-27 01:57:34 UTC) #3
http://codereview.chromium.org/27255/diff/1001/2002
File webkit/glue/chromium_bridge_impl.cc (right):

http://codereview.chromium.org/27255/diff/1001/2002#newcode276
Line 276: } else if (!strcmp(name, "linux-checkbox-off")) {
On 2009/02/27 01:52:55, tony wrote:
> Nit: We should probably be consistent with the other webkit resources and name
> these linuxCheckboOff, etc.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd