MD Settings: Update Bluetooth toggle UI to match spec.

MD Settings: Update Bluetooth toggle UI to match spec.

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2725463002
Cr-Commit-Position: refs/heads/master@{#453495}
Committed: https://chromium.googlesource.com/chromium/src/+/a064e51b3f526c950dc03b4ccfe678202e922ad1

[stevenjb, 2017-02-27 22:34:06]

Description was changed from

==========
MD Settings: Update Bluetooth toggle UI to match spec.

BUG=673946
==========

to

==========
MD Settings: Update Bluetooth toggle UI to match spec.

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-27 23:59:44]

stevenjb@chromium.org changed reviewers:
+ fukino@chromium.org

[stevenjb, 2017-02-27 23:59:45]

Note: The Internet code will also use 'deviceOn' and 'deviceOff' which is why I
renamed them.

[fukino, 2017-02-28 02:37:09]

lgtm with nits

https://codereview.chromium.org/2725463002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(left):

https://codereview.chromium.org/2725463002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:338:
{"bluetoothDisabled", IDS_SETTINGS_BLUETOOTH_DISABLED},
Could you remove the string id from settings_strings.grpd?

https://codereview.chromium.org/2725463002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:341:
{"bluetoothEnabled", IDS_SETTINGS_BLUETOOTH_ENABLED},
ditto

https://codereview.chromium.org/2725463002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:349:
{"bluetoothOff", IDS_SETTINGS_BLUETOOTH_OFF},
ditto

[stevenjb, 2017-02-28 03:04:42]

https://codereview.chromium.org/2725463002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(left):

https://codereview.chromium.org/2725463002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:338:
{"bluetoothDisabled", IDS_SETTINGS_BLUETOOTH_DISABLED},
On 2017/02/28 02:37:09, fukino wrote:
> Could you remove the string id from settings_strings.grpd?

Oops, thanks done.

https://codereview.chromium.org/2725463002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:341:
{"bluetoothEnabled", IDS_SETTINGS_BLUETOOTH_ENABLED},
On 2017/02/28 02:37:09, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/2725463002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:349:
{"bluetoothOff", IDS_SETTINGS_BLUETOOTH_OFF},
On 2017/02/28 02:37:09, fukino wrote:
> ditto

Done.

[stevenjb, 2017-02-28 03:05:01]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-02-28 03:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2725463002/#ps40001
(title: "Elim unused IDS")

[commit-bot: I haz the power, 2017-02-28 03:05:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 04:36:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488251101040680,
"parent_rev": "138493453d9928b3b467939da9d19691831e02ba", "commit_rev":
"a064e51b3f526c950dc03b4ccfe678202e922ad1"}

[commit-bot: I haz the power, 2017-02-28 04:36:55]

Description was changed from

==========
MD Settings: Update Bluetooth toggle UI to match spec.

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Update Bluetooth toggle UI to match spec.

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2725463002
Cr-Commit-Position: refs/heads/master@{#453495}
Committed:
https://chromium.googlesource.com/chromium/src/+/a064e51b3f526c950dc03b4ccfe6...
==========

[commit-bot: I haz the power, 2017-02-28 04:36:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a064e51b3f526c950dc03b4ccfe6...