Don't exit SetBounds early for X11Window.

Don't exit SetBounds early for X11Window.

If X11WindowBase::SetBounds() exits early when the bounds haven't
changed this breaks changing the device scale factor. Use the same logic
as WindowTreeHostX11. We check if anything has changed in origin/bounds
before calling XConfigureNotify. WindowTreeHostPlatform does it's own
checks afterwards to notify observers.

BUG=664570
Review-Url: https://codereview.chromium.org/2725383002
Cr-Commit-Position: refs/heads/master@{#454960}
Committed: https://chromium.googlesource.com/chromium/src/+/d0454d552d477db039a8e4b4ae923c87887c02dd

[kylechar, 2017-03-03 20:15:52]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2017-03-04 02:38:39]

> ... this breaks changing the device scale factor.

Can you clarify why? Does changing device-scale-factor happen through a call to
SetBounds()? Is that weird, or can it be better?

[kylechar, 2017-03-06 16:02:55]

On 2017/03/04 02:38:39, sadrul wrote:
> > ... this breaks changing the device scale factor.
> 
> Can you clarify why? Does changing device-scale-factor happen through a call
to
> SetBounds()? Is that weird, or can it be better?

DisplayManagerTest.TestDeviceScaleOnlyChange and
DisplayManagerTest.UpdateMouseCursorAfterRotateZoom fail with Ozone X11 before
this change.
 
WindowTreeHost has the assumption that if you call SetBoundsInPixels() with the
same pixel size but the device scale factor has changed then it needs to notify
the observers that the DIP size has changed. TestDeviceScaleOnlyChange maybe
doesn't make sense outside of development purposes, because why would a display
change device scale factor but nothing else, but there is an ash debug shortcut
to change the scale factor at runtime...

[sadrul, 2017-03-06 20:24:49]

lgtm

[kylechar, 2017-03-06 20:31:50]

Added a comment to explain. Thanks sadrul!

[kylechar, 2017-03-06 20:32:24]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 20:33:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-03-06 21:03:24]

The CQ bit was unchecked by kylechar@chromium.org

[kylechar, 2017-03-06 21:03:24]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-03-06 21:03:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2725383002/#ps40001
(title: "Add comment.")

[commit-bot: I haz the power, 2017-03-06 21:04:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 21:25:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488834204404730,
"parent_rev": "3ab8c816603c456a39f4302c4611b892986de293", "commit_rev":
"d0454d552d477db039a8e4b4ae923c87887c02dd"}

[commit-bot: I haz the power, 2017-03-06 21:26:04]

Description was changed from

==========
Don't exit SetBounds early for X11Window.

If X11WindowBase::SetBounds() exits early when the bounds haven't
changed this breaks changing the device scale factor. Use the same logic
as WindowTreeHostX11. We check if anything has changed in origin/bounds
before calling XConfigureNotify. WindowTreeHostPlatform does it's own
checks afterwards to notify observers.

BUG=664570
==========

to

==========
Don't exit SetBounds early for X11Window.

If X11WindowBase::SetBounds() exits early when the bounds haven't
changed this breaks changing the device scale factor. Use the same logic
as WindowTreeHostX11. We check if anything has changed in origin/bounds
before calling XConfigureNotify. WindowTreeHostPlatform does it's own
checks afterwards to notify observers.

BUG=664570

Review-Url: https://codereview.chromium.org/2725383002
Cr-Commit-Position: refs/heads/master@{#454960}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0454d552d477db039a8e4b4ae92...
==========

[commit-bot: I haz the power, 2017-03-06 21:26:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d0454d552d477db039a8e4b4ae92...