Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2725343002: Migrate WTF::LinkedHashSet/ListHashSet::last() to ::back() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::LinkedHashSet/ListHashSet::last() to ::back() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2725343002 Cr-Commit-Position: refs/heads/master@{#455227} Committed: https://chromium.googlesource.com/chromium/src/+/7279ec4f24f817ebf896786e0497cea494658243

Patch Set 1 #

Patch Set 2 : add missing file #

Patch Set 3 : argh missed another reference #

Patch Set 4 : OK this is all of them I swear #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSetTest.cpp View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 28 (24 generated)
pilgrim_google
3 years, 9 months ago (2017-03-07 16:21:18 UTC) #19
haraken
LGTM
3 years, 9 months ago (2017-03-07 18:00:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725343002/80001
3 years, 9 months ago (2017-03-07 21:05:53 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 21:46:52 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7279ec4f24f817ebf896786e0497...

Powered by Google App Engine
This is Rietveld 408576698