Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2725333002: [wasm] Also unwrap exported debugged functions (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Also unwrap exported debugged functions The previous fix (http://crrev.com/2720813002) was problematic for functions containing i64 parameters or returns. Those would throw a TypeError when called via WASM_TO_JS and JS_TO_WASM. Instead, we now unwrap the WASM_INTERPRETER_ENTRY function and call it directly. This removes the option to later redirect back to the original wasm function, but this functionality is not needed currently. Plus drive-by fix to put functions in anonymous namespace in wasm-compiler.cc. R=ahaas@chromium.org, titzer@chromium.org BUG=v8:5971, v8:5822 Review-Url: https://codereview.chromium.org/2725333002 Cr-Commit-Position: refs/heads/master@{#43603} Committed: https://chromium.googlesource.com/v8/v8/+/66964e68e44afe6dcbf1e7495ae08e8fc7a6964c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Clemens Hammacher
Andreas spotted this problem in the previous fix.
3 years, 9 months ago (2017-03-03 15:29:33 UTC) #5
titzer
lgtm
3 years, 9 months ago (2017-03-06 07:16:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725333002/1
3 years, 9 months ago (2017-03-06 09:25:38 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 09:53:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/66964e68e44afe6dcbf1e7495ae08e8fc7a...

Powered by Google App Engine
This is Rietveld 408576698