Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2725293004: Add a deprecation message to rtcpMuxPolicy of negotiate. (Closed)

Created:
3 years, 9 months ago by foolip
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=chromium:685727 Review-Url: https://codereview.chromium.org/2720763004 Cr-Commit-Position: refs/heads/master@{#453771} (cherry picked from commit 918bb2c91f07a2cce51cea68554bd56566dec0dc) Review-Url: https://codereview.chromium.org/2725293004 . Cr-Commit-Position: refs/branch-heads/2987@{#750} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f820422f2b7196ef6c410558b4fdc50ad7f613ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/external/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
foolip
3 years, 9 months ago (2017-03-03 15:28:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f820422f2b7196ef6c410558b4fdc50ad7f613ad.

Powered by Google App Engine
This is Rietveld 408576698