Handle null callbacks in OnFaviconDownloaded

Handle null callbacks in OnFaviconDownloaded

All callback are now optional for the IconFetcher.
(This fixes a regression and enables the proper background fetching of
large icons for new NTPs.)

BUG=698159, 694270
Review-Url: https://codereview.chromium.org/2725293002
Cr-Commit-Position: refs/heads/master@{#454565}
Committed: https://chromium.googlesource.com/chromium/src/+/f2dcc909a45160613a7ebb5717ec5b6a93cfdce3

[fhorschig, 2017-03-03 10:22:24]

fhorschig@chromium.org changed reviewers:
+ treib@chromium.org

[fhorschig, 2017-03-03 10:22:24]

Hey Marc,
would you please have a look at this crash fix?

[fhorschig, 2017-03-03 10:26:38]

The CQ bit was checked by fhorschig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 10:26:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-03-03 10:29:42]

lgtm

Please check whether this needs to be merged.

https://codereview.chromium.org/2725293002/diff/1/components/ntp_tiles/icon_c...
File components/ntp_tiles/icon_cacher_impl.cc (right):

https://codereview.chromium.org/2725293002/diff/1/components/ntp_tiles/icon_c...
components/ntp_tiles/icon_cacher_impl.cc:87: if (!icon_available.is_null()) {
optional: I think you can just write "if (icon_available_callback)"

https://codereview.chromium.org/2725293002/diff/1/components/ntp_tiles/icon_c...
File components/ntp_tiles/icon_cacher_impl_unittest.cc (right):

https://codereview.chromium.org/2725293002/diff/1/components/ntp_tiles/icon_c...
components/ntp_tiles/icon_cacher_impl_unittest.cc:278: TEST_F(IconCacherTest,
HandlesEmptyClosuresNicely) {
nit: s/Closures/Callbacks/ ?
(The fact that they have no params IMO doesn't really matter here)

[fhorschig, 2017-03-03 10:35:26]

Yes, merging is likely. I will look out for the BP announcement.

https://codereview.chromium.org/2725293002/diff/1/components/ntp_tiles/icon_c...
File components/ntp_tiles/icon_cacher_impl.cc (right):

https://codereview.chromium.org/2725293002/diff/1/components/ntp_tiles/icon_c...
components/ntp_tiles/icon_cacher_impl.cc:87: if (!icon_available.is_null()) {
On 2017/03/03 10:29:42, Marc Treib wrote:
> optional: I think you can just write "if (icon_available_callback)"

Done.

https://codereview.chromium.org/2725293002/diff/1/components/ntp_tiles/icon_c...
File components/ntp_tiles/icon_cacher_impl_unittest.cc (right):

https://codereview.chromium.org/2725293002/diff/1/components/ntp_tiles/icon_c...
components/ntp_tiles/icon_cacher_impl_unittest.cc:278: TEST_F(IconCacherTest,
HandlesEmptyClosuresNicely) {
On 2017/03/03 10:29:42, Marc Treib wrote:
> nit: s/Closures/Callbacks/ ?
> (The fact that they have no params IMO doesn't really matter here)

Done.

[fhorschig, 2017-03-03 10:36:31]

The CQ bit was checked by fhorschig@chromium.org

[fhorschig, 2017-03-03 10:36:31]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2725293002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-03-03 10:36:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 11:16:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488537391221050,
"parent_rev": "c63e571885b21aa510dc323ecb1c5bc18f1ed29b", "commit_rev":
"f2dcc909a45160613a7ebb5717ec5b6a93cfdce3"}

[commit-bot: I haz the power, 2017-03-03 11:17:28]

Description was changed from

==========
Handle null callbacks in OnFaviconDownloaded

All callback are now optional for the IconFetcher.
(This fixes a regression and enables the proper background fetching of
large icons for new NTPs.)

BUG=698159,694270
==========

to

==========
Handle null callbacks in OnFaviconDownloaded

All callback are now optional for the IconFetcher.
(This fixes a regression and enables the proper background fetching of
large icons for new NTPs.)

BUG=698159,694270

Review-Url: https://codereview.chromium.org/2725293002
Cr-Commit-Position: refs/heads/master@{#454565}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2dcc909a45160613a7ebb5717ec...
==========

[commit-bot: I haz the power, 2017-03-03 11:17:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2dcc909a45160613a7ebb5717ec...