Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 2725153002: Merged: [runtime] Mark old JSGlobalProxy's map as unstable when an iframe navigates away. (Closed)

Created:
3 years, 9 months ago by Igor Sheludko
Modified:
3 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

Merged: [runtime] Mark old JSGlobalProxy's map as unstable when an iframe navigates away. Revision: 1c7f83980e3b29a25bb36cc54be56d3af997e166 BUG=chromium:683667 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2725153002 . Cr-Commit-Position: refs/branch-heads/5.8@{#6} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/f81c002f5db86eb407024d27c892d211cdf07c85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -22 lines) Patch
M src/d8.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/d8.cc View 5 chunks +45 lines, -16 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -5 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-683667.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Igor Sheludko
3 years, 9 months ago (2017-03-02 12:49:06 UTC) #1
Igor Sheludko
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 9 months ago (2017-03-02 12:49:08 UTC) #2
Toon Verwaest
lgtm
3 years, 9 months ago (2017-03-02 12:50:54 UTC) #3
Igor Sheludko
3 years, 9 months ago (2017-03-02 12:51:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f81c002f5db86eb407024d27c892d211cdf07c85.

Powered by Google App Engine
This is Rietveld 408576698