Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: components/doodle/doodle_types.h

Issue 2725143003: [Doodle] Pull time_to_live out of DoodleConfig (Closed)
Patch Set: mastiz review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/doodle/doodle_service_unittest.cc ('k') | components/doodle/doodle_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/doodle/doodle_types.h
diff --git a/components/doodle/doodle_types.h b/components/doodle/doodle_types.h
index 1317c80ccd47bdd0ddb013033b8fcb5ac18b95b1..d97b50bd0fb0b05e90ad8e16fbbdaae4fc746b9c 100644
--- a/components/doodle/doodle_types.h
+++ b/components/doodle/doodle_types.h
@@ -5,7 +5,6 @@
#ifndef COMPONENTS_DOODLE_DOODLE_TYPES_H_
#define COMPONENTS_DOODLE_DOODLE_TYPES_H_
-#include "base/time/time.h"
#include "url/gurl.h"
namespace doodle {
@@ -52,9 +51,8 @@ struct DoodleConfig {
DoodleConfig(const DoodleConfig& config); // = default;
~DoodleConfig();
- // Checks whether this config is "equivalent" to the other. This compares all
- // fields for equality, except for |expiry_date|.
- bool IsEquivalent(const DoodleConfig& other) const;
+ bool operator==(const DoodleConfig& other) const;
+ bool operator!=(const DoodleConfig& other) const;
DoodleType doodle_type;
std::string alt_text;
@@ -68,9 +66,6 @@ struct DoodleConfig {
DoodleImage large_cta_image;
DoodleImage transparent_large_image;
- // TODO(treib,fhorschig): Don't expose this? Clients don't care about it.
- base::TimeDelta time_to_live;
-
// Copying and assignment allowed.
};
« no previous file with comments | « components/doodle/doodle_service_unittest.cc ('k') | components/doodle/doodle_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698