Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: components/doodle/doodle_types.cc

Issue 2725143003: [Doodle] Pull time_to_live out of DoodleConfig (Closed)
Patch Set: mastiz review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/doodle/doodle_types.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/doodle/doodle_types.cc
diff --git a/components/doodle/doodle_types.cc b/components/doodle/doodle_types.cc
index 7468d2b8f87e656456520756d89802ae1fc90925..d88221fced0aac20bfa7902ed9c06421ebe08ac7 100644
--- a/components/doodle/doodle_types.cc
+++ b/components/doodle/doodle_types.cc
@@ -15,10 +15,7 @@ bool DoodleImage::operator!=(const DoodleImage& other) const {
return !(*this == other);
}
-bool DoodleConfig::IsEquivalent(const DoodleConfig& other) const {
- // Note: This compares all fields except for |time_to_live|, which by
- // definition isn't constant over time, and shouldn't be in DoodleConfig in
- // the first place.
+bool DoodleConfig::operator==(const DoodleConfig& other) const {
return doodle_type == other.doodle_type && alt_text == other.alt_text &&
interactive_html == other.interactive_html &&
search_url == other.search_url && target_url == other.target_url &&
@@ -28,4 +25,8 @@ bool DoodleConfig::IsEquivalent(const DoodleConfig& other) const {
transparent_large_image == other.transparent_large_image;
}
+bool DoodleConfig::operator!=(const DoodleConfig& other) const {
+ return !(*this == other);
+}
+
} // namespace doodle
« no previous file with comments | « components/doodle/doodle_types.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698