Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: components/arc/arc_util_unittest.cc

Issue 2725113002: Enable ARC kiosk mode always when ARC is available (Closed)
Patch Set: feedback2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/arc_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/arc_util_unittest.cc
diff --git a/components/arc/arc_util_unittest.cc b/components/arc/arc_util_unittest.cc
index dd803cbbda1a6ef10c54a54a1c8a9e3f93846f01..a39c92bbc15000dd76a49158bd464bbb1174fa52 100644
--- a/components/arc/arc_util_unittest.cc
+++ b/components/arc/arc_util_unittest.cc
@@ -80,7 +80,9 @@ TEST_F(ArcUtilTest, IsArcAvailable_Installed) {
// Not available, by-default, too.
EXPECT_FALSE(IsArcAvailable());
- EXPECT_FALSE(IsArcKioskAvailable());
+
+ // ARC is available in kiosk mode if installed.
+ EXPECT_TRUE(IsArcKioskAvailable());
{
ScopedArcFeature feature(true);
@@ -90,7 +92,7 @@ TEST_F(ArcUtilTest, IsArcAvailable_Installed) {
{
ScopedArcFeature feature(false);
EXPECT_FALSE(IsArcAvailable());
- EXPECT_FALSE(IsArcKioskAvailable());
+ EXPECT_TRUE(IsArcKioskAvailable());
}
// If ARC is installed, IsArcAvailable() should return true when EnableARC
@@ -99,7 +101,9 @@ TEST_F(ArcUtilTest, IsArcAvailable_Installed) {
// Not available, by-default, too.
EXPECT_FALSE(IsArcAvailable());
- EXPECT_FALSE(IsArcKioskAvailable());
+
+ // ARC is available in kiosk mode if installed.
+ EXPECT_TRUE(IsArcKioskAvailable());
{
ScopedArcFeature feature(true);
@@ -109,23 +113,10 @@ TEST_F(ArcUtilTest, IsArcAvailable_Installed) {
{
ScopedArcFeature feature(false);
EXPECT_FALSE(IsArcAvailable());
- EXPECT_FALSE(IsArcKioskAvailable());
+ EXPECT_TRUE(IsArcKioskAvailable());
}
}
-TEST_F(ArcUtilTest, IsArcAvailable_OnlyKioskSupported) {
- // Regardless of FeatureList, IsArcAvailable() should return true.
- auto* command_line = base::CommandLine::ForCurrentProcess();
- command_line->InitFromArgv({"", "--enable-arc"});
- EXPECT_TRUE(IsArcAvailable());
- EXPECT_TRUE(IsArcKioskAvailable());
-
- command_line->InitFromArgv(
- {"", "--arc-availability=installed-only-kiosk-supported"});
- EXPECT_FALSE(IsArcAvailable());
- EXPECT_TRUE(IsArcKioskAvailable());
-}
-
TEST_F(ArcUtilTest, IsArcAvailable_OfficiallySupported) {
// Regardless of FeatureList, IsArcAvailable() should return true.
auto* command_line = base::CommandLine::ForCurrentProcess();
« no previous file with comments | « components/arc/arc_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698