Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: components/arc/arc_util_unittest.cc

Issue 2725113002: Enable ARC kiosk mode always when ARC is available (Closed)
Patch Set: feedback2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/arc/arc_util.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/arc_util.h" 5 #include "components/arc/arc_util.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 EXPECT_FALSE(IsArcAvailable()); 73 EXPECT_FALSE(IsArcAvailable());
74 EXPECT_FALSE(IsArcKioskAvailable()); 74 EXPECT_FALSE(IsArcKioskAvailable());
75 } 75 }
76 76
77 // If ARC is installed, IsArcAvailable() should return true when EnableARC 77 // If ARC is installed, IsArcAvailable() should return true when EnableARC
78 // feature is set. 78 // feature is set.
79 command_line->InitFromArgv({"", "--arc-available"}); 79 command_line->InitFromArgv({"", "--arc-available"});
80 80
81 // Not available, by-default, too. 81 // Not available, by-default, too.
82 EXPECT_FALSE(IsArcAvailable()); 82 EXPECT_FALSE(IsArcAvailable());
83 EXPECT_FALSE(IsArcKioskAvailable()); 83
84 // ARC is available in kiosk mode if installed.
85 EXPECT_TRUE(IsArcKioskAvailable());
84 86
85 { 87 {
86 ScopedArcFeature feature(true); 88 ScopedArcFeature feature(true);
87 EXPECT_TRUE(IsArcAvailable()); 89 EXPECT_TRUE(IsArcAvailable());
88 EXPECT_TRUE(IsArcKioskAvailable()); 90 EXPECT_TRUE(IsArcKioskAvailable());
89 } 91 }
90 { 92 {
91 ScopedArcFeature feature(false); 93 ScopedArcFeature feature(false);
92 EXPECT_FALSE(IsArcAvailable()); 94 EXPECT_FALSE(IsArcAvailable());
93 EXPECT_FALSE(IsArcKioskAvailable()); 95 EXPECT_TRUE(IsArcKioskAvailable());
94 } 96 }
95 97
96 // If ARC is installed, IsArcAvailable() should return true when EnableARC 98 // If ARC is installed, IsArcAvailable() should return true when EnableARC
97 // feature is set. 99 // feature is set.
98 command_line->InitFromArgv({"", "--arc-availability=installed"}); 100 command_line->InitFromArgv({"", "--arc-availability=installed"});
99 101
100 // Not available, by-default, too. 102 // Not available, by-default, too.
101 EXPECT_FALSE(IsArcAvailable()); 103 EXPECT_FALSE(IsArcAvailable());
102 EXPECT_FALSE(IsArcKioskAvailable()); 104
105 // ARC is available in kiosk mode if installed.
106 EXPECT_TRUE(IsArcKioskAvailable());
103 107
104 { 108 {
105 ScopedArcFeature feature(true); 109 ScopedArcFeature feature(true);
106 EXPECT_TRUE(IsArcAvailable()); 110 EXPECT_TRUE(IsArcAvailable());
107 EXPECT_TRUE(IsArcKioskAvailable()); 111 EXPECT_TRUE(IsArcKioskAvailable());
108 } 112 }
109 { 113 {
110 ScopedArcFeature feature(false); 114 ScopedArcFeature feature(false);
111 EXPECT_FALSE(IsArcAvailable()); 115 EXPECT_FALSE(IsArcAvailable());
112 EXPECT_FALSE(IsArcKioskAvailable()); 116 EXPECT_TRUE(IsArcKioskAvailable());
113 } 117 }
114 } 118 }
115 119
116 TEST_F(ArcUtilTest, IsArcAvailable_OnlyKioskSupported) {
117 // Regardless of FeatureList, IsArcAvailable() should return true.
118 auto* command_line = base::CommandLine::ForCurrentProcess();
119 command_line->InitFromArgv({"", "--enable-arc"});
120 EXPECT_TRUE(IsArcAvailable());
121 EXPECT_TRUE(IsArcKioskAvailable());
122
123 command_line->InitFromArgv(
124 {"", "--arc-availability=installed-only-kiosk-supported"});
125 EXPECT_FALSE(IsArcAvailable());
126 EXPECT_TRUE(IsArcKioskAvailable());
127 }
128
129 TEST_F(ArcUtilTest, IsArcAvailable_OfficiallySupported) { 120 TEST_F(ArcUtilTest, IsArcAvailable_OfficiallySupported) {
130 // Regardless of FeatureList, IsArcAvailable() should return true. 121 // Regardless of FeatureList, IsArcAvailable() should return true.
131 auto* command_line = base::CommandLine::ForCurrentProcess(); 122 auto* command_line = base::CommandLine::ForCurrentProcess();
132 command_line->InitFromArgv({"", "--enable-arc"}); 123 command_line->InitFromArgv({"", "--enable-arc"});
133 EXPECT_TRUE(IsArcAvailable()); 124 EXPECT_TRUE(IsArcAvailable());
134 EXPECT_TRUE(IsArcKioskAvailable()); 125 EXPECT_TRUE(IsArcKioskAvailable());
135 126
136 command_line->InitFromArgv({"", "--arc-availability=officially-supported"}); 127 command_line->InitFromArgv({"", "--arc-availability=officially-supported"});
137 EXPECT_TRUE(IsArcAvailable()); 128 EXPECT_TRUE(IsArcAvailable());
138 EXPECT_TRUE(IsArcKioskAvailable()); 129 EXPECT_TRUE(IsArcKioskAvailable());
(...skipping 28 matching lines...) Expand all
167 auto* command_line = base::CommandLine::ForCurrentProcess(); 158 auto* command_line = base::CommandLine::ForCurrentProcess();
168 command_line->InitFromArgv({""}); 159 command_line->InitFromArgv({""});
169 EXPECT_FALSE(IsArcOptInVerificationDisabled()); 160 EXPECT_FALSE(IsArcOptInVerificationDisabled());
170 161
171 command_line->InitFromArgv({"", "--disable-arc-opt-in-verification"}); 162 command_line->InitFromArgv({"", "--disable-arc-opt-in-verification"});
172 EXPECT_TRUE(IsArcOptInVerificationDisabled()); 163 EXPECT_TRUE(IsArcOptInVerificationDisabled());
173 } 164 }
174 165
175 } // namespace 166 } // namespace
176 } // namespace arc 167 } // namespace arc
OLDNEW
« no previous file with comments | « components/arc/arc_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698