Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2725053007: Reland Migrate Object.prototype.valueOf to CSA (Closed)

Created:
3 years, 9 months ago by rongjie
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Migrate Object.prototype.valueOf to CSA Original issue: https://codereview.chromium.org/2724833002/ BUG=v8:6005 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel R=bmeurer@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2725053007 Cr-Commit-Position: refs/heads/master@{#43566} Committed: https://chromium.googlesource.com/v8/v8/+/dbac9770116af27c483ab550ca32998a767e9a72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M src/bootstrapper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/debug/debug-evaluate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/js/v8natives.js View 3 chunks +1 line, -11 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
rongjie
I deleted a few local branches, so I can't send patches to old CL anymore.
3 years, 9 months ago (2017-03-03 05:35:26 UTC) #1
Benedikt Meurer
You can just reconnect with git cl issue <number>. But this way is also fine. ...
3 years, 9 months ago (2017-03-03 05:37:38 UTC) #2
Yang
On 2017/03/03 05:37:38, Benedikt Meurer wrote: > You can just reconnect with git cl issue ...
3 years, 9 months ago (2017-03-03 05:38:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725053007/1
3 years, 9 months ago (2017-03-03 05:39:54 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 06:30:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dbac9770116af27c483ab550ca32998a767...

Powered by Google App Engine
This is Rietveld 408576698