Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2725053006: Change VisibleUnits::previousBoundary to return Position rather than VisiblePosition (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change VisibleUnits::previousBoundary to return Position rather than VisiblePosition This is preparation for letting |startOfWord| and |endOfWord| return uncanonicalized Position. BUG=697725 Review-Url: https://codereview.chromium.org/2725053006 Cr-Commit-Position: refs/heads/master@{#454820} Committed: https://chromium.googlesource.com/chromium/src/+/02c4e35bd076d9f12d7f42947d21078a244caa14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 7 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yoichio
3 years, 9 months ago (2017-03-03 05:17:00 UTC) #7
yoichio
ptal
3 years, 9 months ago (2017-03-06 02:02:34 UTC) #8
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-06 02:26:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725053006/1
3 years, 9 months ago (2017-03-06 02:26:38 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 03:50:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02c4e35bd076d9f12d7f42947d21...

Powered by Google App Engine
This is Rietveld 408576698