Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2724983002: [TTS] Update Test config for server experiment. (Closed)

Created:
3 years, 9 months ago by Donn Denman
Modified:
3 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Theresa
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Update Test config for server experiment. Adds sending the client-controlled experiment flag for the current experiment (use "First Coca Card") so that gets test coverage and is enabled for developer builds. BUG=692351 Review-Url: https://codereview.chromium.org/2724983002 Cr-Commit-Position: refs/heads/master@{#454164} Committed: https://chromium.googlesource.com/chromium/src/+/2d9a101aacc4bc19bb2082a050ae2604fd368b85

Patch Set 1 #

Patch Set 2 : Just a rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M testing/variations/fieldtrial_testing_config.json View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Donn Denman
Ilya, PTAL at your leisure.
3 years, 9 months ago (2017-03-02 00:36:13 UTC) #4
Ilya Sherman
lgtm
3 years, 9 months ago (2017-03-02 00:36:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724983002/1
3 years, 9 months ago (2017-03-02 00:47:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/376255)
3 years, 9 months ago (2017-03-02 00:59:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724983002/20001
3 years, 9 months ago (2017-03-02 01:42:01 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 03:36:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2d9a101aacc4bc19bb2082a050ae...

Powered by Google App Engine
This is Rietveld 408576698