Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2724963002: Remove non-MD code from AudioDetailedView (Closed)

Created:
3 years, 9 months ago by mohsen
Modified:
3 years, 9 months ago
Reviewers:
tdanderson, sadrul
CC:
chromium-reviews, kalyank, oshima+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-MD code from AudioDetailedView BUG=687798 TEST=none Review-Url: https://codereview.chromium.org/2724963002 Cr-Commit-Position: refs/heads/master@{#454602} Committed: https://chromium.googlesource.com/chromium/src/+/93695f6919948c77e7961914429523485af7e5de

Patch Set 1 #

Patch Set 2 : Updated #

Total comments: 3

Patch Set 3 : Removed unused resource #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -116 lines) Patch
M ash/common/system/chromeos/audio/audio_detailed_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/chromeos/audio/audio_detailed_view.cc View 1 2 3 5 chunks +29 lines, -64 lines 0 comments Download
M ash/common/system/chromeos/audio/volume_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/tray/hover_highlight_view.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/common/system/tray/hover_highlight_view.cc View 2 chunks +0 lines, -40 lines 0 comments Download
D ui/views/resources/default_100_percent/cros/menu_check.png View 1 2 Binary file 0 comments Download
D ui/views/resources/default_200_percent/cros/menu_check.png View 1 2 Binary file 0 comments Download
M ui/views/resources/views_resources.grd View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
mohsen
Please take a look...
3 years, 9 months ago (2017-03-01 23:01:45 UTC) #4
tdanderson
LGTM with one request https://codereview.chromium.org/2724963002/diff/20001/ash/common/system/tray/hover_highlight_view.cc File ash/common/system/tray/hover_highlight_view.cc (left): https://codereview.chromium.org/2724963002/diff/20001/ash/common/system/tray/hover_highlight_view.cc#oldcode257 ash/common/system/tray/hover_highlight_view.cc:257: views::Label* HoverHighlightView::AddCheckableLabel(const base::string16& text, Thanks ...
3 years, 9 months ago (2017-03-02 20:48:50 UTC) #5
mohsen
https://codereview.chromium.org/2724963002/diff/20001/ash/common/system/tray/hover_highlight_view.cc File ash/common/system/tray/hover_highlight_view.cc (left): https://codereview.chromium.org/2724963002/diff/20001/ash/common/system/tray/hover_highlight_view.cc#oldcode266 ash/common/system/tray/hover_highlight_view.cc:266: rb.GetImageNamed(IDR_MENU_CHECK).ToImageSkia(); On 2017/03/02 at 20:48:49, tdanderson wrote: > Looks ...
3 years, 9 months ago (2017-03-03 06:59:18 UTC) #8
mohsen
+sadrul@: for changes in ui/views/resources/.
3 years, 9 months ago (2017-03-03 16:57:40 UTC) #16
sadrul
lgtm
3 years, 9 months ago (2017-03-03 17:00:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724963002/60001
3 years, 9 months ago (2017-03-03 17:06:08 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 17:10:53 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/93695f6919948c77e79619144295...

Powered by Google App Engine
This is Rietveld 408576698