When uploading updates to baselines/expectations, pass patchset title with "-t".

When uploading updates to baselines/expectations, pass patchset title with "-t".

BUG=693792
Review-Url: https://codereview.chromium.org/2724953002
Cr-Commit-Position: refs/heads/master@{#454289}
Committed: https://chromium.googlesource.com/chromium/src/+/6e035cf67feec1c6547bf3a919bc3882636ac1af

[qyearsley, 2017-03-01 22:29:45]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org, tandrii@chromium.org

[qyearsley, 2017-03-01 22:29:46]

One-character change!

I believe that this should enable importer to upload update patchsets now on
Gerrit.

Filed related bug http://crbug.com/697625

[jeffcarp, 2017-03-02 05:42:26]

lgtm

[tandrii(chromium), 2017-03-02 14:49:28]

https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:432:
self.git_cl.run(['upload', '-t', message, '--gerrit'])
this will work for re-upload, but for initial upload. For now, you'd need to do
smth like:
 if git_cl.run('issue'):
   git_cl.run(['upload', '-t', message, '--gerrit'])
 else:
   git_cl.run(['upload', '-m', message, '--gerrit'])

[qyearsley, 2017-03-02 16:02:38]

On 2017/03/02 at 14:49:28, tandrii wrote:
>
https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Sc...
> File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):
> 
>
https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:432:
self.git_cl.run(['upload', '-t', message, '--gerrit'])
> this will work for re-upload, but for initial upload. For now, you'd need to
do smth like:
>  if git_cl.run('issue'):
>    git_cl.run(['upload', '-t', message, '--gerrit'])
>  else:
>    git_cl.run(['upload', '-m', message, '--gerrit'])

It should be OK in this particular place in the code, because in this place the
git cl upload command is only invoked for the second patchset (the first
patchset is uploaded in the _upload_cl method).

[qyearsley, 2017-03-02 16:02:45]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-03-02 16:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2017-03-02 16:06:10]

On 2017/03/02 16:02:38, qyearsley wrote:
> On 2017/03/02 at 14:49:28, tandrii wrote:
> >
>
https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Sc...
> > File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):
> > 
> >
>
https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Sc...
> > third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:432:
> self.git_cl.run(['upload', '-t', message, '--gerrit'])
> > this will work for re-upload, but for initial upload. For now, you'd need to
> do smth like:
> >  if git_cl.run('issue'):
> >    git_cl.run(['upload', '-t', message, '--gerrit'])
> >  else:
> >    git_cl.run(['upload', '-m', message, '--gerrit'])
> 
> It should be OK in this particular place in the code, because in this place
the
> git cl upload command is only invoked for the second patchset (the first
> patchset is uploaded in the _upload_cl method).

ah, i see now. Yeah, LGTM!

[commit-bot: I haz the power, 2017-03-02 17:12:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488470565243620, "parent_rev":
"4b326a561bf0feaae081fe6f2037cde4d25a8fd9", "commit_rev":
"6e035cf67feec1c6547bf3a919bc3882636ac1af"}

[commit-bot: I haz the power, 2017-03-02 17:13:00]

Description was changed from

==========
When uploading updates to baselines/expectations, pass patchset title with "-t".

BUG=693792
==========

to

==========
When uploading updates to baselines/expectations, pass patchset title with "-t".

BUG=693792

Review-Url: https://codereview.chromium.org/2724953002
Cr-Commit-Position: refs/heads/master@{#454289}
Committed:
https://chromium.googlesource.com/chromium/src/+/6e035cf67feec1c6547bf3a919bc...
==========

[commit-bot: I haz the power, 2017-03-02 17:13:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e035cf67feec1c6547bf3a919bc...