Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2724953002: When uploading updates to baselines/expectations, pass patchset title with "-t". (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When uploading updates to baselines/expectations, pass patchset title with "-t". BUG=693792 Review-Url: https://codereview.chromium.org/2724953002 Cr-Commit-Position: refs/heads/master@{#454289} Committed: https://chromium.googlesource.com/chromium/src/+/6e035cf67feec1c6547bf3a919bc3882636ac1af

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 11 (4 generated)
qyearsley
One-character change! I believe that this should enable importer to upload update patchsets now on ...
3 years, 9 months ago (2017-03-01 22:29:46 UTC) #2
jeffcarp
lgtm
3 years, 9 months ago (2017-03-02 05:42:26 UTC) #3
tandrii(chromium)
https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right): https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py#newcode432 third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:432: self.git_cl.run(['upload', '-t', message, '--gerrit']) this will work for re-upload, ...
3 years, 9 months ago (2017-03-02 14:49:28 UTC) #4
qyearsley
On 2017/03/02 at 14:49:28, tandrii wrote: > https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py > File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right): > > https://codereview.chromium.org/2724953002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py#newcode432 ...
3 years, 9 months ago (2017-03-02 16:02:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724953002/1
3 years, 9 months ago (2017-03-02 16:03:05 UTC) #7
tandrii(chromium)
On 2017/03/02 16:02:38, qyearsley wrote: > On 2017/03/02 at 14:49:28, tandrii wrote: > > > ...
3 years, 9 months ago (2017-03-02 16:06:10 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 17:13:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e035cf67feec1c6547bf3a919bc...

Powered by Google App Engine
This is Rietveld 408576698