Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2724903006: Check package manager to verify VrCore is not installed (Closed)

Created:
3 years, 9 months ago by amp
Modified:
3 years, 9 months ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check package manager to verify VrCore is not installed BUG=698312 Review-Url: https://codereview.chromium.org/2724903006 Cr-Commit-Position: refs/heads/master@{#454669} Committed: https://chromium.googlesource.com/chromium/src/+/55964a5fe4fd3e1615944b0971439dd667db7521

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
amp
3 years, 9 months ago (2017-03-03 19:09:18 UTC) #3
bshe
lgtm with nit https://codereview.chromium.org/2724903006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java (right): https://codereview.chromium.org/2724903006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java#newcode50 chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java:50: // when it should just be ...
3 years, 9 months ago (2017-03-03 19:48:39 UTC) #4
amp
https://codereview.chromium.org/2724903006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java (right): https://codereview.chromium.org/2724903006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java#newcode50 chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java:50: // when it should just be an update. On ...
3 years, 9 months ago (2017-03-03 20:25:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724903006/20001
3 years, 9 months ago (2017-03-03 20:32:54 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 21:00:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55964a5fe4fd3e1615944b097143...

Powered by Google App Engine
This is Rietveld 408576698