Check package manager to verify VrCore is not installed

Check package manager to verify VrCore is not installed

BUG=698312
Review-Url: https://codereview.chromium.org/2724903006
Cr-Commit-Position: refs/heads/master@{#454669}
Committed: https://chromium.googlesource.com/chromium/src/+/55964a5fe4fd3e1615944b0971439dd667db7521

[amp, 2017-03-03 19:08:19]

Description was changed from

==========
Check package manager to verify VrCore is not installed

BUG=698312
==========

to

==========
Check package manager to verify VrCore is not installed

BUG=698312,670166
==========

[amp, 2017-03-03 19:09:17]

amp@chromium.org changed reviewers:
+ bshe@chromium.org

[bshe, 2017-03-03 19:48:39]

lgtm with nit

https://codereview.chromium.org/2724903006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java
(right):

https://codereview.chromium.org/2724903006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java:50:
// when it should just be an update.
nit: document why do we need to double check

[amp, 2017-03-03 20:25:00]

https://codereview.chromium.org/2724903006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java
(right):

https://codereview.chromium.org/2724903006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java:50:
// when it should just be an update.
On 2017/03/03 19:48:39, bshe wrote:
> nit: document why do we need to double check

Done.

[amp, 2017-03-03 20:25:06]

The CQ bit was checked by amp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 20:25:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amp, 2017-03-03 20:31:58]

Description was changed from

==========
Check package manager to verify VrCore is not installed

BUG=698312,670166
==========

to

==========
Check package manager to verify VrCore is not installed

BUG=698312
==========

[amp, 2017-03-03 20:32:07]

The CQ bit was unchecked by amp@chromium.org

[amp, 2017-03-03 20:32:10]

The CQ bit was checked by amp@chromium.org

[amp, 2017-03-03 20:32:11]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2724903006/#ps20001
(title: "update comments")

[commit-bot: I haz the power, 2017-03-03 20:32:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 20:58:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488573130966530,
"parent_rev": "37a79590935319ad34fcf7e101b852c023821672", "commit_rev":
"55964a5fe4fd3e1615944b0971439dd667db7521"}

[commit-bot: I haz the power, 2017-03-03 21:00:36]

Description was changed from

==========
Check package manager to verify VrCore is not installed

BUG=698312
==========

to

==========
Check package manager to verify VrCore is not installed

BUG=698312

Review-Url: https://codereview.chromium.org/2724903006
Cr-Commit-Position: refs/heads/master@{#454669}
Committed:
https://chromium.googlesource.com/chromium/src/+/55964a5fe4fd3e1615944b097143...
==========

[commit-bot: I haz the power, 2017-03-03 21:00:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55964a5fe4fd3e1615944b097143...