Updates exception and adds rety to ExecuteAsyncJavaScript

Updates exception and adds rety to ExecuteAsyncJavaScript.
This should help to improve stability issues on telemetry runs, especially Windows.

BUG=698308
Review-Url: https://codereview.chromium.org/2724903005
Cr-Commit-Position: refs/heads/master@{#454992}
Committed: https://chromium.googlesource.com/chromium/src/+/0712a2ecd73b028bb2e67ca7dfde62172ff593de

[cliffordcheng1, 2017-03-03 19:02:34]

Description was changed from

==========
Updates exception.
Adds rety to ExecuteAsyncJavaScript.
This should help to improve stability issues on telemetry runs, especially
Windows.

BUG=698308
==========

to

==========
Updates exception and adds rety to ExecuteAsyncJavaScript.
This should help to improve stability issues on telemetry runs, especially
Windows.

BUG=698308
==========

[cliffordcheng1, 2017-03-03 19:03:36]

cliffordcheng@chromium.org changed reviewers:
+ imcheng@chromium.org, leilei@chromium.org

[imcheng, 2017-03-03 19:27:00]

A couple of questions.

- do we know why the the stopSession() call is not working when the test fails?
- is the error reason surfaced in the test logic, or in the logs? IIUC,
session.stop() has a 30s timeout built in and will invoke the error callback in
that case.

[cliffordcheng1, 2017-03-03 22:21:20]

On 2017/03/03 19:27:00, imcheng wrote:
> A couple of questions.
> 
> - do we know why the the stopSession() call is not working when the test
fails?
> - is the error reason surfaced in the test logic, or in the logs? IIUC,
> session.stop() has a 30s timeout built in and will invoke the error callback
in
> that case.

1. I am not sure why stopSession() failed in the cpu_memory telemetry test.
In the test, after calling stopSession(), we keep checking if 'currentSession'
still exists every second for 30s.
I tried to repro issue on Windows machine by running the failed test for a few
times, but I didn't see any issue at all.
I suspect it's because we run a few tests before this one and receiver could get
slowed down when handling consecutive requests in short period of time.
I think adding a retry and send the call for a couple more times may help to
resolve the issue.

2. The error is from the test logic.
We don't enable logs in test runs because it can impact the performance and
that's bad for telemetry tests.

[imcheng, 2017-03-06 21:19:04]

lgtm.

I have a suggestion on how to surface the error for stopSession() or other API
calls. You can keep a boolean on the page that gets updated when the success or
error callback gets invoked. In the latter case, the error message can be stored
in another variable which can be evaluated from the test and surfaced there.

[cliffordcheng1, 2017-03-06 23:03:28]

On 2017/03/06 21:19:04, imcheng wrote:
> lgtm.
> 
> I have a suggestion on how to surface the error for stopSession() or other API
> calls. You can keep a boolean on the page that gets updated when the success
or
> error callback gets invoked. In the latter case, the error message can be
stored
> in another variable which can be evaluated from the test and surfaced there.

I see. That's a good idea.
Let me check this in and then I will prepare this change in another CL.

[cliffordcheng1, 2017-03-06 23:03:33]

The CQ bit was checked by cliffordcheng@chromium.org

[commit-bot: I haz the power, 2017-03-06 23:04:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:16:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488841413047880, "parent_rev":
"ad7a59f9e40a877f4283021cb0e888e9ac5fb04a", "commit_rev":
"0712a2ecd73b028bb2e67ca7dfde62172ff593de"}

[commit-bot: I haz the power, 2017-03-06 23:17:10]

Description was changed from

==========
Updates exception and adds rety to ExecuteAsyncJavaScript.
This should help to improve stability issues on telemetry runs, especially
Windows.

BUG=698308
==========

to

==========
Updates exception and adds rety to ExecuteAsyncJavaScript.
This should help to improve stability issues on telemetry runs, especially
Windows.

BUG=698308

Review-Url: https://codereview.chromium.org/2724903005
Cr-Commit-Position: refs/heads/master@{#454992}
Committed:
https://chromium.googlesource.com/chromium/src/+/0712a2ecd73b028bb2e67ca7dfde...
==========

[commit-bot: I haz the power, 2017-03-06 23:17:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0712a2ecd73b028bb2e67ca7dfde...