Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2724853002: Revert last 4 commits by lrn@ (Closed)

Created:
3 years, 9 months ago by Dmitry Stefantsov
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert last 4 commits by @lrn Reverted commits: * ef097edad6e5e4e82c3891ad2d8f9cde8fa8cfdc. ("Make Analyzer, VM and dart2js accept URI strings as part-of library identifier.") * e8e1857814c2c0d9ae2c5431f89a84523667259b. ("Fix bad example of URI part-of to be bad, not good.") * 58f7a92ede378ed16fc6d18cdf2a4e56bc27c2e1. ("Add changelog entry for allowing URI in part-of.") * a4a7d98dcea609a527fc3ed2316b68a249e9192c. ("Use FutureOr in Completer.complete.") TBR=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/9c340f9eb18cba1b2c2dc5a57b3909d2dc47cde5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -186 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +3 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +2 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +0 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M sdk/lib/async/future.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 3 chunks +3 lines, -3 lines 0 comments Download
D tests/language/part_of_uri2_part.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/language/part_of_uri2_part2.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/language/part_of_uri2_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language/part_of_uri_part.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/language/part_of_uri_part2.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/language/part_of_uri_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Dmitry Stefantsov
3 years, 9 months ago (2017-03-01 15:43:03 UTC) #2
Dmitry Stefantsov
3 years, 9 months ago (2017-03-01 15:45:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c340f9eb18cba1b2c2dc5a57b3909d2dc47cde5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698