Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: pkg/analyzer/test/src/dart/analysis/driver_test.dart

Issue 2724853002: Revert last 4 commits by lrn@ (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/context/context_test.dart ('k') | pkg/analyzer/test/src/task/dart_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/dart/analysis/driver_test.dart
diff --git a/pkg/analyzer/test/src/dart/analysis/driver_test.dart b/pkg/analyzer/test/src/dart/analysis/driver_test.dart
index 53c4702f348ec0136b88e3e2509665a7c8433c9e..79e551fb2d420bb234117154b3c4e7f60f5d5fbd 100644
--- a/pkg/analyzer/test/src/dart/analysis/driver_test.dart
+++ b/pkg/analyzer/test/src/dart/analysis/driver_test.dart
@@ -414,14 +414,9 @@ part of lib;
AnalysisResult libResult = await driver.getResult(lib);
List<AnalysisError> errors = libResult.errors;
- if (libResult.unit.element.context.analysisOptions.enableUriInPartOf) {
- // TODO(28522): Should cause an error for wrong library name.
- expect(errors, hasLength(0));
- } else {
- expect(errors, hasLength(1));
- expect(errors[0].errorCode,
- ResolverErrorCode.MISSING_LIBRARY_DIRECTIVE_WITH_PART);
- }
+ expect(errors, hasLength(1));
+ expect(errors[0].errorCode,
+ ResolverErrorCode.MISSING_LIBRARY_DIRECTIVE_WITH_PART);
}
test_analyze_resolveDirectives_error_partOfDifferentLibrary_byName() async {
« no previous file with comments | « pkg/analyzer/test/src/context/context_test.dart ('k') | pkg/analyzer/test/src/task/dart_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698