Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2724793002: Revert of memory-infra: Finish moving memory_infra from TracingController (Closed)

Created:
3 years, 9 months ago by Primiano Tucci (use gerrit)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, fmeawad
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of memory-infra: Finish moving memory_infra from TracingController (patchset #25 id:470001 of https://codereview.chromium.org/2694083005/ ) Reason for revert: Unfortunately this broke lot of memory-infra metrics and caused flakiness in various bot. Have to revert because this is causing problems to the sheriff rotation. More details: crbug.com/697384 : metrics broken crbug.com/697062 : memory dumps failing on webview Original issue's description: > memory-infra: Finish moving memory_infra from TracingController > > This finishes moving memory instrumentation code from TracingController > to its own location in //services/resource_coordinator. > > BUG=679830 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2694083005 > Cr-Commit-Position: refs/heads/master@{#453243} > Committed: https://chromium.googlesource.com/chromium/src/+/e7bee2f02da7fb7afbdb387197ad9461d8d2eba2 TBR=hjd@chromium.org,oysteine@chromium.org,ssid@chromium.org,jam@chromium.org,kenrb@chromium.org,chiniforooshan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=679830, 697384 Committed: https://chromium.googlesource.com/chromium/src/+/74b034f002cf4f4f5456ed349d57672635e8c46b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+939 lines, -422 lines) Patch
M base/trace_event/memory_dump_manager.h View 6 chunks +11 lines, -15 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 5 chunks +21 lines, -3 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/tracing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/tracing/child/child_memory_dump_manager_delegate_impl.h View 1 chunk +85 lines, -0 lines 0 comments Download
A components/tracing/child/child_memory_dump_manager_delegate_impl.cc View 1 chunk +114 lines, -0 lines 0 comments Download
M components/tracing/child/child_trace_message_filter.h View 4 chunks +17 lines, -0 lines 0 comments Download
M components/tracing/child/child_trace_message_filter.cc View 7 chunks +63 lines, -14 lines 0 comments Download
A components/tracing/child/child_trace_message_filter_browsertest.cc View 1 chunk +326 lines, -0 lines 0 comments Download
M content/browser/browser_main.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/tracing/memory_tracing_browsertest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/tracing/trace_message_filter.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/tracing/trace_message_filter.cc View 3 chunks +29 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 6 chunks +33 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 4 chunks +172 lines, -0 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 2 chunks +0 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/resource_coordinator/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M services/resource_coordinator/memory/coordinator/coordinator_impl.h View 4 chunks +4 lines, -10 lines 0 comments Download
M services/resource_coordinator/memory/coordinator/coordinator_impl.cc View 5 chunks +12 lines, -33 lines 0 comments Download
M services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc View 7 chunks +10 lines, -16 lines 0 comments Download
M services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h View 2 chunks +5 lines, -34 lines 0 comments Download
M services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc View 3 chunks +15 lines, -105 lines 0 comments Download
D services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl_unittest.cc View 1 chunk +0 lines, -139 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Primiano Tucci (use gerrit)
Created Revert of memory-infra: Finish moving memory_infra from TracingController
3 years, 9 months ago (2017-03-01 11:33:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724793002/1
3 years, 9 months ago (2017-03-01 11:33:54 UTC) #3
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-01 12:35:58 UTC) #7
ssid
3 years, 9 months ago (2017-03-01 18:25:28 UTC) #9
On 2017/03/01 12:35:58, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

This seems to be committed at
https://chromium.googlesource.com/chromium/src/+/74b034f002cf4f4f5456ed349d57...
Issue is not closed because of some cq error. Marking this closed

Powered by Google App Engine
This is Rietveld 408576698