|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by Marton Hunyady Modified:
3 years, 9 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInitialize source field of PolicyMap::Entry
Defaults to lowest priority source (POLICY_SOURCE_ENTERPRISE_DEFAULT).
BUG=697174
Review-Url: https://codereview.chromium.org/2724763002
Cr-Commit-Position: refs/heads/master@{#453940}
Committed: https://chromium.googlesource.com/chromium/src/+/e1ac111de29d1ca2f661c5ff46a6897495f389d5
Patch Set 1 #
Total comments: 2
Patch Set 2 : Move default values to header file. #
Messages
Total messages: 25 (15 generated)
Description was changed from ========== Initialize source field of PolicyMap::Entry BUG=697174 ========== to ========== Initialize source field of PolicyMap::Entry Defaults to lowest priority source (POLICY_SOURCE_ENTERPRISE_DEFAULT). BUG=697174 ==========
hunyadym@chromium.org changed reviewers: + thakis@chromium.org
PTAL
The CQ bit was checked by hunyadym@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, thanks!
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
hunyadym@chromium.org changed reviewers: + tnagel@chromium.org
tnagel@chromium.org: PTAL
https://codereview.chromium.org/2724763002/diff/1/components/policy/core/comm... File components/policy/core/common/policy_map.cc (right): https://codereview.chromium.org/2724763002/diff/1/components/policy/core/comm... components/policy/core/common/policy_map.cc:18: source(POLICY_SOURCE_ENTERPRISE_DEFAULT) {} Please move initialization to .h file.
https://codereview.chromium.org/2724763002/diff/1/components/policy/core/comm... File components/policy/core/common/policy_map.cc (right): https://codereview.chromium.org/2724763002/diff/1/components/policy/core/comm... components/policy/core/common/policy_map.cc:18: source(POLICY_SOURCE_ENTERPRISE_DEFAULT) {} On 2017/03/01 14:21:27, Thiemo Nagel wrote: > Please move initialization to .h file. Done, did you mean this?
The CQ bit was checked by hunyadym@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> Done, did you mean this? Yes. Lgtm.
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2724763002/#ps20001 (title: "Move default values to header file.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488381896537340,
"parent_rev": "98783dd475ef6dda3fd39dbbe880641da2ccaabf", "commit_rev":
"e1ac111de29d1ca2f661c5ff46a6897495f389d5"}
Message was sent while issue was closed.
Description was changed from ========== Initialize source field of PolicyMap::Entry Defaults to lowest priority source (POLICY_SOURCE_ENTERPRISE_DEFAULT). BUG=697174 ========== to ========== Initialize source field of PolicyMap::Entry Defaults to lowest priority source (POLICY_SOURCE_ENTERPRISE_DEFAULT). BUG=697174 Review-Url: https://codereview.chromium.org/2724763002 Cr-Commit-Position: refs/heads/master@{#453940} Committed: https://chromium.googlesource.com/chromium/src/+/e1ac111de29d1ca2f661c5ff46a6... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e1ac111de29d1ca2f661c5ff46a6... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
