Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2724763002: Initialize source field of PolicyMap::Entry (Closed)

Created:
3 years, 9 months ago by Marton Hunyady
Modified:
3 years, 9 months ago
Reviewers:
Thiemo Nagel, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize source field of PolicyMap::Entry Defaults to lowest priority source (POLICY_SOURCE_ENTERPRISE_DEFAULT). BUG=697174 Review-Url: https://codereview.chromium.org/2724763002 Cr-Commit-Position: refs/heads/master@{#453940} Committed: https://chromium.googlesource.com/chromium/src/+/e1ac111de29d1ca2f661c5ff46a6897495f389d5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move default values to header file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M components/policy/core/common/policy_map.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/policy/core/common/policy_map.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Marton Hunyady
PTAL
3 years, 9 months ago (2017-03-01 12:24:06 UTC) #3
Nico
lgtm, thanks!
3 years, 9 months ago (2017-03-01 12:24:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724763002/1
3 years, 9 months ago (2017-03-01 13:01:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/375571)
3 years, 9 months ago (2017-03-01 13:08:15 UTC) #11
Marton Hunyady
tnagel@chromium.org: PTAL
3 years, 9 months ago (2017-03-01 13:22:51 UTC) #13
Thiemo Nagel
https://codereview.chromium.org/2724763002/diff/1/components/policy/core/common/policy_map.cc File components/policy/core/common/policy_map.cc (right): https://codereview.chromium.org/2724763002/diff/1/components/policy/core/common/policy_map.cc#newcode18 components/policy/core/common/policy_map.cc:18: source(POLICY_SOURCE_ENTERPRISE_DEFAULT) {} Please move initialization to .h file.
3 years, 9 months ago (2017-03-01 14:21:27 UTC) #14
Marton Hunyady
https://codereview.chromium.org/2724763002/diff/1/components/policy/core/common/policy_map.cc File components/policy/core/common/policy_map.cc (right): https://codereview.chromium.org/2724763002/diff/1/components/policy/core/common/policy_map.cc#newcode18 components/policy/core/common/policy_map.cc:18: source(POLICY_SOURCE_ENTERPRISE_DEFAULT) {} On 2017/03/01 14:21:27, Thiemo Nagel wrote: > ...
3 years, 9 months ago (2017-03-01 14:37:42 UTC) #15
Thiemo Nagel
> Done, did you mean this? Yes. Lgtm.
3 years, 9 months ago (2017-03-01 14:51:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724763002/20001
3 years, 9 months ago (2017-03-01 15:25:02 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 15:56:39 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1ac111de29d1ca2f661c5ff46a6...

Powered by Google App Engine
This is Rietveld 408576698