Check not to insert nullptr to HeapHashSet<WeakMember>

Check not to insert nullptr to HeapHashSet<WeakMember>

This patch ensures that nullptr is not inserted into CSSFontSelector and
FontCache::fontCacheClients(), in order to track de-referencing nullptr
on iterations.

If there were any such instances, we will crash early in a different
signature.

BUG=581698, 689949, 696231
Review-Url: https://codereview.chromium.org/2724753002
Cr-Commit-Position: refs/heads/master@{#453879}
Committed: https://chromium.googlesource.com/chromium/src/+/8f4c753ac4abed4f3d0d37e7612fa15fac4b29c5

[kojii, 2017-03-01 06:30:13]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 06:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-01 06:33:55]

Description was changed from

==========
weakset

BUG=
==========

to

==========
Check not to insert nullptr to HeapHashSet<WeakMember>

This patch ensures that nullptr is not inserted into CSSFontSelector and
FontCache::fontCacheClients(), in order to track de-referencing nullptr
on iterations.

BUG=581698, 689949, 696231
==========

[kojii, 2017-03-01 06:34:50]

kojii@chromium.org changed reviewers:
+ haraken@chromium.org, sigbjornf@opera.com

[kojii, 2017-03-01 06:34:50]

PTAL. This is #2 of https://crbug.com/696231#c13

[haraken, 2017-03-01 06:37:28]

LGTM

[sof, 2017-03-01 06:49:48]

lgtm

[kojii, 2017-03-01 07:11:54]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2017-03-01 07:11:56]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-03-01 07:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-01 07:50:35]

Description was changed from

==========
Check not to insert nullptr to HeapHashSet<WeakMember>

This patch ensures that nullptr is not inserted into CSSFontSelector and
FontCache::fontCacheClients(), in order to track de-referencing nullptr
on iterations.

BUG=581698, 689949, 696231
==========

to

==========
Check not to insert nullptr to HeapHashSet<WeakMember>

This patch ensures that nullptr is not inserted into CSSFontSelector and
FontCache::fontCacheClients(), in order to track de-referencing nullptr
on iterations.

If there were any such instances, we will crash early in a different
signature.

BUG=581698, 689949, 696231
==========

[commit-bot: I haz the power, 2017-03-01 08:00:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488352316473530, "parent_rev":
"480fa30589acd71427e3f902fd7916e87c41f5d9", "commit_rev":
"8f4c753ac4abed4f3d0d37e7612fa15fac4b29c5"}

[commit-bot: I haz the power, 2017-03-01 08:01:07]

Description was changed from

==========
Check not to insert nullptr to HeapHashSet<WeakMember>

This patch ensures that nullptr is not inserted into CSSFontSelector and
FontCache::fontCacheClients(), in order to track de-referencing nullptr
on iterations.

If there were any such instances, we will crash early in a different
signature.

BUG=581698, 689949, 696231
==========

to

==========
Check not to insert nullptr to HeapHashSet<WeakMember>

This patch ensures that nullptr is not inserted into CSSFontSelector and
FontCache::fontCacheClients(), in order to track de-referencing nullptr
on iterations.

If there were any such instances, we will crash early in a different
signature.

BUG=581698, 689949, 696231

Review-Url: https://codereview.chromium.org/2724753002
Cr-Commit-Position: refs/heads/master@{#453879}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f4c753ac4abed4f3d0d37e7612f...
==========

[commit-bot: I haz the power, 2017-03-01 08:01:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f4c753ac4abed4f3d0d37e7612f...