Chromium Code Reviews
DescriptionRevert of Allow $TMPDIR to set temporary directory on OS X. (patchset #8 id:140001 of https://codereview.chromium.org/2713293002/ )
Reason for revert:
Looks like this broke mac compile https://build.chromium.org/p/chromium/buildstatus?builder=Mac&number=24213
Original issue's description:
> Allow $TMPDIR to set temporary directory on OS X.
>
> This allows the continuous integration builds to be more hermetic by
> supplying a managed value for $TMPDIR and having chromium + tests respect
> it.
>
> NSTemporaryDirectory takes its value directly from a non-overridable
> confstr(_CS_DARWIN_USER_TEMP_DIR) call internally. This CL brings OS X
> more in line with Windows and Linux which both respect an environment
> variable ($TEMP and $TMPDIR respectively).
>
> BUG=696803
>
> Review-Url: https://codereview.chromium.org/2713293002
> Cr-Commit-Position: refs/heads/master@{#453835}
> Committed: https://chromium.googlesource.com/chromium/src/+/7b5db573b3ebbc32ee4608163b9ba7e68750ee9a
TBR=lambroslambrou@chromium.org,jam@chromium.org,maruel@chromium.org,mark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=696803
Review-Url: https://codereview.chromium.org/2724733002
Cr-Commit-Position: refs/heads/master@{#453841}
Committed: https://chromium.googlesource.com/chromium/src/+/cedd448c905837fc74d0b793305733da3c88e900
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||