Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2724733002: Revert of Allow $TMPDIR to set temporary directory on OS X. (Closed)

Created:
3 years, 9 months ago by iannucci
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, chromoting-reviews_chromium.org, vmpstr+watch_chromium.org, Vadim Sh., Nico
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow $TMPDIR to set temporary directory on OS X. (patchset #8 id:140001 of https://codereview.chromium.org/2713293002/ ) Reason for revert: Looks like this broke mac compile https://build.chromium.org/p/chromium/buildstatus?builder=Mac&number=24213 Original issue's description: > Allow $TMPDIR to set temporary directory on OS X. > > This allows the continuous integration builds to be more hermetic by > supplying a managed value for $TMPDIR and having chromium + tests respect > it. > > NSTemporaryDirectory takes its value directly from a non-overridable > confstr(_CS_DARWIN_USER_TEMP_DIR) call internally. This CL brings OS X > more in line with Windows and Linux which both respect an environment > variable ($TEMP and $TMPDIR respectively). > > BUG=696803 > > Review-Url: https://codereview.chromium.org/2713293002 > Cr-Commit-Position: refs/heads/master@{#453835} > Committed: https://chromium.googlesource.com/chromium/src/+/7b5db573b3ebbc32ee4608163b9ba7e68750ee9a TBR=lambroslambrou@chromium.org,jam@chromium.org,maruel@chromium.org,mark@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=696803 Review-Url: https://codereview.chromium.org/2724733002 Cr-Commit-Position: refs/heads/master@{#453841} Committed: https://chromium.googlesource.com/chromium/src/+/cedd448c905837fc74d0b793305733da3c88e900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -35 lines) Patch
M base/files/file_util_mac.mm View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/file_select_helper_mac.mm View 1 chunk +8 lines, -14 lines 0 comments Download
M remoting/host/mac/me2me_preference_pane.mm View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
iannucci
Created Revert of Allow $TMPDIR to set temporary directory on OS X.
3 years, 9 months ago (2017-03-01 04:44:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724733002/1
3 years, 9 months ago (2017-03-01 04:44:25 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 04:46:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cedd448c905837fc74d0b7933057...

Powered by Google App Engine
This is Rietveld 408576698