Add AltSvcFrameTest for non-empty origin on non-zero frame.

Add AltSvcFrameTest for non-empty origin on non-zero frame.

BUG=696653
Review-Url: https://codereview.chromium.org/2724703002
Cr-Commit-Position: refs/heads/master@{#453925}
Committed: https://chromium.googlesource.com/chromium/src/+/7b2a21a7ff27c79e88cc5a64cece2890e8aacb1f

[Bence, 2017-03-01 00:48:39]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 00:49:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-03-01 01:50:15]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2017-03-01 01:50:16]

Ryan: PTAL.  Thank you.

[commit-bot: I haz the power, 2017-03-01 02:01:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 02:01:17]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-03-01 03:38:47]

lgtm

https://codereview.chromium.org/2724703002/diff/1/net/spdy/spdy_session_unitt...
File net/spdy/spdy_session_unittest.cc (right):

https://codereview.chromium.org/2724703002/diff/1/net/spdy/spdy_session_unitt...
net/spdy/spdy_session_unittest.cc:5648:
DoNotProcessAltSvcFrameWithNonEmptyOriginOnNonZeroStream) {
What does "OnNonZeroStream" mean here?

[Bence, 2017-03-01 12:48:31]

Thank you.  I'm checking this in now, but please let me know if you can think of
any improvements I can make in a follow-up.

https://codereview.chromium.org/2724703002/diff/1/net/spdy/spdy_session_unitt...
File net/spdy/spdy_session_unittest.cc (right):

https://codereview.chromium.org/2724703002/diff/1/net/spdy/spdy_session_unitt...
net/spdy/spdy_session_unittest.cc:5648:
DoNotProcessAltSvcFrameWithNonEmptyOriginOnNonZeroStream) {
On 2017/03/01 03:38:47, Ryan Hamilton wrote:
> What does "OnNonZeroStream" mean here?

A stream that has a stream id different from zero.  As opposed to "OnZeroStream"
in the previous test case, where it means a stream with stream id zero.  I can
easily rename ZeroStream to StreamZero, but let me know if you can think of a
way to improve the name of this test case.

Let me at least add a comment with an RFC reference to make it clearer.

[Bence, 2017-03-01 12:48:34]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-03-01 12:48:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2724703002/#ps20001
(title: "Add comment; rename one existing test.")

[commit-bot: I haz the power, 2017-03-01 12:48:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 13:27:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488372514704880,
"parent_rev": "1e466e19d1e65d1a4c4b0e54c744a357ce30d9aa", "commit_rev":
"7b2a21a7ff27c79e88cc5a64cece2890e8aacb1f"}

[commit-bot: I haz the power, 2017-03-01 13:28:03]

Description was changed from

==========
Add AltSvcFrameTest for non-empty origin on non-zero frame.

BUG=696653
==========

to

==========
Add AltSvcFrameTest for non-empty origin on non-zero frame.

BUG=696653

Review-Url: https://codereview.chromium.org/2724703002
Cr-Commit-Position: refs/heads/master@{#453925}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b2a21a7ff27c79e88cc5a64cece...
==========

[commit-bot: I haz the power, 2017-03-01 13:28:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b2a21a7ff27c79e88cc5a64cece...

[Ryan Hamilton, 2017-03-01 20:41:53]

https://codereview.chromium.org/2724703002/diff/1/net/spdy/spdy_session_unitt...
File net/spdy/spdy_session_unittest.cc (right):

https://codereview.chromium.org/2724703002/diff/1/net/spdy/spdy_session_unitt...
net/spdy/spdy_session_unittest.cc:5648:
DoNotProcessAltSvcFrameWithNonEmptyOriginOnNonZeroStream) {
On 2017/03/01 12:48:31, Bence wrote:
> On 2017/03/01 03:38:47, Ryan Hamilton wrote:
> > What does "OnNonZeroStream" mean here?
> 
> A stream that has a stream id different from zero.  As opposed to
"OnZeroStream"
> in the previous test case, where it means a stream with stream id zero.  I can
> easily rename ZeroStream to StreamZero, but let me know if you can think of a
> way to improve the name of this test case.
> 
> Let me at least add a comment with an RFC reference to make it clearer.

I suspect I'm missing something, but is there a stream_id in this test?

[Bence, 2017-03-02 00:30:07]

> I suspect I'm missing something, but is there a stream_id in this test?

Yes, the single argument of explicit SpdyAltSvcIR::SpdyAltSvcIR(SpdyStreamId
stream_id),
see
https://cs.chromium.org/chromium/src/net/spdy/spdy_protocol.h?q=spdyaltsvcir&...,
called in lines 5629 and 5649 here.

[Ryan Hamilton, 2017-03-02 01:12:48]

On 2017/03/02 00:30:07, Bence wrote:
> > I suspect I'm missing something, but is there a stream_id in this test?
> 
> Yes, the single argument of explicit SpdyAltSvcIR::SpdyAltSvcIR(SpdyStreamId
> stream_id),
> see
>
https://cs.chromium.org/chromium/src/net/spdy/spdy_protocol.h?q=spdyaltsvcir&...,
> called in lines 5629 and 5649 here.

Ah, thanks!  Good point :)

I might be a good idea to do:

foo(/* stream_id */ 1);

or

SpdyStreamId id = 1;
foo(1);

To make the literals more readable.  But whatever! :)