[ios] Moves the Find in Page APIs into FindTabHelper.

[ios] Moves the Find in Page APIs into FindTabHelper.

Hides FindInPageController as an implementation detail of FindTabHelper and
moves public APIs to be on FindTabHelper instead.

BUG=691073
Review-Url: https://codereview.chromium.org/2724683002
Cr-Commit-Position: refs/heads/master@{#457543}
Committed: https://chromium.googlesource.com/chromium/src/+/005a643c735aceb7b6075a82026d39227f67dc21

[rohitrao (ping after 24h), 2017-03-10 15:02:59]

Description was changed from

==========
Starts to move code out of BVC

BUG=
==========

to

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Calls to find in page will now originate in FindTabHelper rather than in
BrowserViewController.

BUG=691073
==========

[rohitrao (ping after 24h), 2017-03-10 15:03:08]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 15:03:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-03-10 15:04:13]

Description was changed from

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Calls to find in page will now originate in FindTabHelper rather than in
BrowserViewController.

BUG=691073
==========

to

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Calls to find in page will now originate in FindTabHelper rather than in
FindInPageController.

BUG=691073
==========

[commit-bot: I haz the power, 2017-03-10 16:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 16:13:03]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rohitrao (ping after 24h), 2017-03-12 21:05:00]

Description was changed from

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Calls to find in page will now originate in FindTabHelper rather than in
FindInPageController.

BUG=691073
==========

to

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Hides FindInPageController as an implementation detail of FindTabHelper and
moves public APIs to be on FindTabHelper instead.

BUG=691073
==========

[rohitrao (ping after 24h), 2017-03-12 21:05:07]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 21:05:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 22:08:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-12 22:08:36]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rohitrao (ping after 24h), 2017-03-13 11:27:36]

Description was changed from

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Hides FindInPageController as an implementation detail of FindTabHelper and
moves public APIs to be on FindTabHelper instead.

BUG=691073
==========

to

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Hides FindInPageController as an implementation detail of FindTabHelper and
moves public APIs to be on FindTabHelper instead.

BUG=691073
==========

[rohitrao (ping after 24h), 2017-03-13 14:39:31]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 14:39:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 16:03:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:03:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rohitrao (ping after 24h), 2017-03-13 16:50:37]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 16:51:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-03-13 16:54:41]

rohitrao@chromium.org changed reviewers:
+ justincohen@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:53:48]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-03-14 13:27:14]

rohitrao@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[rohitrao (ping after 24h), 2017-03-14 13:27:15]

+stk as well

[stkhapugin, 2017-03-14 14:06:15]

lgtm, thanks for looping me in

https://codereview.chromium.org/2724683002/diff/140001/ios/chrome/browser/fin...
File ios/chrome/browser/find_in_page/find_tab_helper.h (right):

https://codereview.chromium.org/2724683002/diff/140001/ios/chrome/browser/fin...
ios/chrome/browser/find_in_page/find_tab_helper.h:44: // searches in the given
|direction|.
Specify how this and other methods can be called wrt completion blocks being not
called yet. 
nit: Worth saying that it will highlight the next/prev result (it's not super
clear from the comment imo).

[rohitrao (ping after 24h), 2017-03-14 14:50:53]

https://codereview.chromium.org/2724683002/diff/140001/ios/chrome/browser/fin...
File ios/chrome/browser/find_in_page/find_tab_helper.h (right):

https://codereview.chromium.org/2724683002/diff/140001/ios/chrome/browser/fin...
ios/chrome/browser/find_in_page/find_tab_helper.h:44: // searches in the given
|direction|.
On 2017/03/14 14:06:15, stkhapugin wrote:
> Specify how this and other methods can be called wrt completion blocks being
not
> called yet. 
> nit: Worth saying that it will highlight the next/prev result (it's not super
> clear from the comment imo).

Added a note about highlighting to the method comment.

I don't fully understand what happens if you call this method twice in a row
before the completion handler runs.  Leaving this out for now, but I'll come
back to it when I convert these calls to take base::Callbacks instead of blocks.

[rohitrao (ping after 24h), 2017-03-14 15:16:46]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 15:17:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 16:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 16:16:48]

Dry run: This issue passed the CQ dry run.

[justincohen, 2017-03-16 14:40:45]

LGTM

[rohitrao (ping after 24h), 2017-03-16 19:11:39]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-03-16 19:11:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2724683002/#ps160001
(title: "Review")

[commit-bot: I haz the power, 2017-03-16 19:12:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 20:52:49]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1489691499548990,
"parent_rev": "80442b74794f7f1b8a932d83024b2096f97d7358", "commit_rev":
"005a643c735aceb7b6075a82026d39227f67dc21"}

[commit-bot: I haz the power, 2017-03-16 20:53:30]

Description was changed from

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Hides FindInPageController as an implementation detail of FindTabHelper and
moves public APIs to be on FindTabHelper instead.

BUG=691073
==========

to

==========
[ios] Moves the Find in Page APIs into FindTabHelper.

Hides FindInPageController as an implementation detail of FindTabHelper and
moves public APIs to be on FindTabHelper instead.

BUG=691073

Review-Url: https://codereview.chromium.org/2724683002
Cr-Commit-Position: refs/heads/master@{#457543}
Committed:
https://chromium.googlesource.com/chromium/src/+/005a643c735aceb7b6075a82026d...
==========

[commit-bot: I haz the power, 2017-03-16 20:53:31]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/005a643c735aceb7b6075a82026d...