Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2724593002: Move MarkupTokenizerInlines.h to core/html (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
kouhei (in TOK)
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eric.carlson_apple.com, gasubic, kinuko+watch, loading-reviews+parser_chromium.org, nessy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MarkupTokenizerInlines.h to core/html This set of helpers is used by HTMLTokenizer and VTTTokenizer - both of which reside in core/html. Review-Url: https://codereview.chromium.org/2724593002 Cr-Commit-Position: refs/heads/master@{#453887} Committed: https://chromium.googlesource.com/chromium/src/+/da0deb9b9f7e997f597b2d7c8dd1f3c38f4ebbea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -100 lines) Patch
M third_party/WebKit/Source/core/html/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/parser/MarkupTokenizerInlines.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/xml/parser/MarkupTokenizerInlines.h View 1 chunk +0 lines, -98 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 9 months ago (2017-03-01 08:53:08 UTC) #6
kouhei (in TOK)
lgtm
3 years, 9 months ago (2017-03-01 08:53:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724593002/1
3 years, 9 months ago (2017-03-01 08:54:05 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 08:58:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da0deb9b9f7e997f597b2d7c8dd1...

Powered by Google App Engine
This is Rietveld 408576698