Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2724533006: MD Settings: Bluetooth: Clean up observers and discovery logic (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Bluetooth: Clean up observers and discovery logic Calling 'stopDiscovery' when the bluetooth adapter is not powered will always fail, and the new UI should always be discovering when the subpage is shown and the device is powered. BUG=695220 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2724533006 Cr-Commit-Position: refs/heads/master@{#454207} Committed: https://chromium.googlesource.com/chromium/src/+/4f2fe086d738f255856393a7eebf743170ac61bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -31 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js View 7 chunks +24 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
stevenjb
Calling 'stopDiscovery' when the bluetooth adapter is not powered will always fail, and the new ...
3 years, 9 months ago (2017-02-28 22:52:54 UTC) #3
fukino
lgtm. Thanks!
3 years, 9 months ago (2017-03-02 03:33:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724533006/1
3 years, 9 months ago (2017-03-02 03:41:53 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 07:44:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f2fe086d738f255856393a7eebf...

Powered by Google App Engine
This is Rietveld 408576698