ChromeDriver test replacements for SafebrowserOn/SafebrowserOff

ChromeDriver test replacements for SafebrowserOn/SafebrowserOff

BUG=680572, 680573
Review-Url: https://codereview.chromium.org/2724503002
Cr-Commit-Position: refs/heads/master@{#454104}
Committed: https://chromium.googlesource.com/chromium/src/+/d25c0f20455f2a7399ffa9e097b0c14f25e18d40

[dougarnett, 2017-02-28 00:36:15]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 00:36:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougarnett, 2017-02-28 00:39:34]

dougarnett@chromium.org changed reviewers:
+ robertogden@chromium.org, sclittle@chromium.org

[dougarnett, 2017-02-28 00:39:35]

My attempt at ChromeDriver test replacements for Safebrowser integration tests
from an interpretation point of view (not deep knowledge). Please also check
adequate mapping to @AndroidOnly and @NotAndroid.

[dougarnett, 2017-02-28 00:39:46]

Description was changed from

==========
ChromeDriver test replacements for SafebrowserOn/SafebrowserOff

BUG=680572, 680573
==========

to

==========
ChromeDriver test replacements for SafebrowserOn/SafebrowserOff

BUG=680572, 680573
==========

[commit-bot: I haz the power, 2017-02-28 00:40:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 00:40:52]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dougarnett, 2017-02-28 00:51:01]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 00:51:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 01:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 01:03:42]

Dry run: This issue passed the CQ dry run.

[Robert Ogden, 2017-03-01 16:57:07]

https://codereview.chromium.org/2724503002/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/safebrowsing.py (right):

https://codereview.chromium.org/2724503002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/safebrowsing.py:18:
t.LoadURL('http://www.ianfette.org/')
Go ahead and use http://testsafebrowsing.appspot.com/s/malware.html instead.

https://codereview.chromium.org/2724503002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/safebrowsing.py:26:
t.LoadURL('http://www.ianfette.org/')
Go ahead and use http://testsafebrowsing.appspot.com/s/malware.html instead.

https://codereview.chromium.org/2724503002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/safebrowsing.py:30:
self.assertEqual('http://www.ianfette.org/', response.url)
Instead of checking the URL, check that is used the proxy with
self.assertHasChromeProxyViaHeader(response)

[dougarnett, 2017-03-01 21:53:37]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 21:54:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougarnett, 2017-03-01 21:55:46]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 21:56:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougarnett, 2017-03-01 21:56:47]

https://codereview.chromium.org/2724503002/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/safebrowsing.py (right):

https://codereview.chromium.org/2724503002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/safebrowsing.py:18:
t.LoadURL('http://www.ianfette.org/')
On 2017/03/01 16:57:07, Robert Ogden wrote:
> Go ahead and use http://testsafebrowsing.appspot.com/s/malware.html instead. 

Done.

https://codereview.chromium.org/2724503002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/safebrowsing.py:26:
t.LoadURL('http://www.ianfette.org/')
On 2017/03/01 16:57:07, Robert Ogden wrote:
> Go ahead and use http://testsafebrowsing.appspot.com/s/malware.html instead. 

Done.

https://codereview.chromium.org/2724503002/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/safebrowsing.py:30:
self.assertEqual('http://www.ianfette.org/', response.url)
On 2017/03/01 16:57:07, Robert Ogden wrote:
> Instead of checking the URL, check that is used the proxy with
> self.assertHasChromeProxyViaHeader(response)

Done.

[Robert Ogden, 2017-03-01 22:05:22]

lgtm

[sclittle, 2017-03-01 22:06:07]

lgtm

[commit-bot: I haz the power, 2017-03-01 22:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:07:18]

Dry run: This issue passed the CQ dry run.

[dougarnett, 2017-03-01 23:44:58]

The CQ bit was checked by dougarnett@chromium.org

[commit-bot: I haz the power, 2017-03-01 23:45:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 23:55:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488411898704550,
"parent_rev": "f5f8823dd3ba11cc8696bfe926654ed7db1f7ed9", "commit_rev":
"d25c0f20455f2a7399ffa9e097b0c14f25e18d40"}

[commit-bot: I haz the power, 2017-03-01 23:55:54]

Description was changed from

==========
ChromeDriver test replacements for SafebrowserOn/SafebrowserOff

BUG=680572, 680573
==========

to

==========
ChromeDriver test replacements for SafebrowserOn/SafebrowserOff

BUG=680572, 680573

Review-Url: https://codereview.chromium.org/2724503002
Cr-Commit-Position: refs/heads/master@{#454104}
Committed:
https://chromium.googlesource.com/chromium/src/+/d25c0f20455f2a7399ffa9e097b0...
==========

[commit-bot: I haz the power, 2017-03-01 23:55:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d25c0f20455f2a7399ffa9e097b0...