Store and propagate a list of applied text decorations.

Source/core/css/resolver/StyleAdjuster.cpp

Index: Source/core/css/resolver/StyleAdjuster.cpp
diff --git a/Source/core/css/resolver/StyleAdjuster.cpp b/Source/core/css/resolver/StyleAdjuster.cpp
index 8f4133988b4b85efbf1714e1c8bf8915c6672f04..24a0a295ecba05aff6b5139e99229b0d104ba17e 100644
--- a/Source/core/css/resolver/StyleAdjuster.cpp
+++ b/Source/core/css/resolver/StyleAdjuster.cpp
@@ -137,7 +137,7 @@ static bool doesNotInheritTextDecoration(const RenderStyle* style, const Element
 {
     return style->display() == TABLE || style->display() == INLINE_TABLE
         || style->display() == INLINE_BLOCK || style->display() == INLINE_BOX || isAtShadowBoundary(e)
-        || style->isFloating() || style->hasOutOfFlowPosition();
+        || style->isFloating() || style->hasOutOfFlowPosition() || isHTMLRTElement(e);

[Julien - ping for review, 2014/05/06 23:29:30]

Is this tested anywhere? Where does the specification says that we can't allow
this to ruby?

[andersr, 2014/05/07 11:17:53]

This was done to replace the behavior in the rendering code, which also avoids
decoration if it encounters a ruby element. I should probably move this change
to a later patch.

We *do* have a test for it, and it *is* in the spec.

"When specified on or propagated to a ruby box, the decorations are propagated
only to the ruby base."

http://www.w3.org/TR/css-text-decor-3/#line-decoration

[Julien - ping for review, 2014/05/09 15:45:50]

Maybe it's related to this patch but the fact that you are mentioning rendering
on a css patch makes me somehow think this belongs to a follow-up change.
Sir, I wish I could read minds but I am limited to the code you write and the
words you put in the description. None of which leads me to believe there is a
test for this part of the change.
Fair enough, I missed that on quick read of the specification.

[andersr, 2014/05/12 11:12:49]

Yes, I agree. Note that I did move this change to the next patch, if that was
unclear.

 }
 
 // FIXME: This helper is only needed because pseudoStyleForElement passes a null
@@ -245,9 +245,9 @@ void StyleAdjuster::adjustRenderStyle(RenderStyle* style, RenderStyle* parentSty
     }
 
     if (doesNotInheritTextDecoration(style, e))
-        style->setTextDecorationsInEffect(style->textDecoration());
-    else
-        style->addToTextDecorationsInEffect(style->textDecoration());
+        style->clearAppliedTextDecorations();
+
+    style->applyTextDecorations();
 
     if (style->overflowX() != OVISIBLE || style->overflowY() != OVISIBLE)
         adjustOverflow(style);