Store and propagate a list of applied text decorations.

Source/core/css/resolver/StyleAdjuster.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 119 matching lines @@
     return BLOCK;
 }
 
 // CSS requires text-decoration to be reset at each DOM element for tables,
 // inline blocks, inline tables, shadow DOM crossings, floating elements,
 // and absolute or relatively positioned elements.
 static bool doesNotInheritTextDecoration(const RenderStyle* style, const Element* e)
 {
     return style->display() == TABLE || style->display() == INLINE_TABLE
         || style->display() == INLINE_BLOCK || style->display() == INLINE_BOX || isAtShadowBoundary(e)
-        || style->isFloating() || style->hasOutOfFlowPosition();
+        || style->isFloating() || style->hasOutOfFlowPosition() || isHTMLRTElement(e);

[Julien - ping for review, 2014/05/06 23:29:30]

Is this tested anywhere? Where does the specification says that we can't allow
this to ruby?

[andersr, 2014/05/07 11:17:53]

This was done to replace the behavior in the rendering code, which also avoids
decoration if it encounters a ruby element. I should probably move this change
to a later patch.

We *do* have a test for it, and it *is* in the spec.

"When specified on or propagated to a ruby box, the decorations are propagated
only to the ruby base."

http://www.w3.org/TR/css-text-decor-3/#line-decoration

[Julien - ping for review, 2014/05/09 15:45:50]

Maybe it's related to this patch but the fact that you are mentioning rendering
on a css patch makes me somehow think this belongs to a follow-up change.
Sir, I wish I could read minds but I am limited to the code you write and the
words you put in the description. None of which leads me to believe there is a
test for this part of the change.
Fair enough, I missed that on quick read of the specification.

[andersr, 2014/05/12 11:12:49]

Yes, I agree. Note that I did move this change to the next patch, if that was
unclear.

 }
 
 // FIXME: This helper is only needed because pseudoStyleForElement passes a null
 // element to adjustRenderStyle, so we can't just use element->isInTopLayer().
 static bool isInTopLayer(const Element* element, const RenderStyle* style)
 {
     return (element && element->isInTopLayer()) || (style && style->styleType() == BACKDROP);
 }
 
 static bool isDisplayFlexibleBox(EDisplay display)
@@ skipping 87 matching lines @@
         style->setZIndex(0);
 
     // will-change:transform should result in the same rendering behavior as having a transform,
     // including the creation of a containing block for fixed position descendants.
     if (!style->hasTransform() && (style->willChangeProperties().contains(CSSPropertyWebkitTransform) || style->willChangeProperties().contains(CSSPropertyTransform))) {
         bool makeIdentity = true;
         style->setTransform(TransformOperations(makeIdentity));
     }
 
     if (doesNotInheritTextDecoration(style, e))
-        style->setTextDecorationsInEffect(style->textDecoration());
-    else
-        style->addToTextDecorationsInEffect(style->textDecoration());
+        style->clearAppliedTextDecorations();
+
+    style->applyTextDecorations();
 
     if (style->overflowX() != OVISIBLE || style->overflowY() != OVISIBLE)
         adjustOverflow(style);
 
     // Cull out any useless layers and also repeat patterns into additional layers.
     style->adjustBackgroundLayers();
     style->adjustMaskLayers();
 
     // Let the theme also have a crack at adjusting the style.
     if (style->hasAppearance())
@@ skipping 185 matching lines @@
     if (style->writingMode() != TopToBottomWritingMode && (style->display() == BOX || style->display() == INLINE_BOX))
         style->setWritingMode(TopToBottomWritingMode);
 
     if (isDisplayFlexibleBox(parentStyle->display()) || isDisplayGridBox(parentStyle->display())) {
         style->setFloating(NoFloat);
         style->setDisplay(equivalentBlockDisplay(style->display(), style->isFloating(), !m_useQuirksModeStyles));
     }
 }
 
 }