Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2724413002: MD Settings: Internet: Show details for known networks (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Show details for known networks This CL adds a show details subpage button for known networks. This will allow non visible known networks to be configured and connected to (for hidden networks). BUG=129289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2724413002 Cr-Commit-Position: refs/heads/master@{#455199} Committed: https://chromium.googlesource.com/chromium/src/+/de034dd8176ef7642646814c4de5d85c35399ec7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + fix comment #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -34 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.html View 1 chunk +58 lines, -32 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.js View 1 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_subpage.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
stevenjb
3 years, 9 months ago (2017-03-02 20:22:36 UTC) #3
michaelpg
https://codereview.chromium.org/2724413002/diff/1/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js File chrome/browser/resources/settings/internet_page/internet_known_networks_page.js (right): https://codereview.chromium.org/2724413002/diff/1/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js#newcode171 chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:171: * Fires a 'show-details' event with |this.networkState| as the ...
3 years, 9 months ago (2017-03-04 01:11:25 UTC) #4
stevenjb
PTAL https://codereview.chromium.org/2724413002/diff/1/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js File chrome/browser/resources/settings/internet_page/internet_known_networks_page.js (right): https://codereview.chromium.org/2724413002/diff/1/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js#newcode171 chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:171: * Fires a 'show-details' event with |this.networkState| as ...
3 years, 9 months ago (2017-03-06 18:38:31 UTC) #5
michaelpg
lgtm
3 years, 9 months ago (2017-03-06 22:10:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724413002/40001
3 years, 9 months ago (2017-03-06 22:53:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395103)
3 years, 9 months ago (2017-03-07 01:33:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724413002/40001
3 years, 9 months ago (2017-03-07 18:31:39 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 20:27:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/de034dd8176ef7642646814c4de5...

Powered by Google App Engine
This is Rietveld 408576698