MD Settings: Internet: Show details for known networks

MD Settings: Internet: Show details for known networks

This CL adds a show details subpage button for known networks.
This will allow non visible known networks to be configured and
connected to (for hidden networks).

BUG=129289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2724413002
Cr-Commit-Position: refs/heads/master@{#455199}
Committed: https://chromium.googlesource.com/chromium/src/+/de034dd8176ef7642646814c4de5d85c35399ec7

[stevenjb, 2017-03-02 20:19:22]

Description was changed from

==========
MD Settings: Internet: Show details for known networks

This CL adds a show details subpage button for known networks.
This will allow non visible known networks to be configured and
connected to (for hidden networks).

BUG=129289
==========

to

==========
MD Settings: Internet: Show details for known networks

This CL adds a show details subpage button for known networks.
This will allow non visible known networks to be configured and
connected to (for hidden networks).

BUG=129289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-03-02 20:22:36]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-03-04 01:11:25]

https://codereview.chromium.org/2724413002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
(right):

https://codereview.chromium.org/2724413002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:171:
* Fires a 'show-details' event with |this.networkState| as the details.
did you mean something else by |this.networkState|?

[stevenjb, 2017-03-06 18:38:31]

PTAL

https://codereview.chromium.org/2724413002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
(right):

https://codereview.chromium.org/2724413002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:171:
* Fires a 'show-details' event with |this.networkState| as the details.
On 2017/03/04 01:11:25, michaelpg wrote:
> did you mean something else by |this.networkState|?

Yep. Copy/pasted this and failed to update the comment. Done.

[michaelpg, 2017-03-06 22:10:47]

lgtm

[stevenjb, 2017-03-06 22:53:00]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-03-06 22:53:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:33:50]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[stevenjb, 2017-03-07 18:30:25]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:31:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 20:26:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488911425637090,
"parent_rev": "9552c2c3a6399668a90723c4d42a3d9862cf4591", "commit_rev":
"de034dd8176ef7642646814c4de5d85c35399ec7"}

[commit-bot: I haz the power, 2017-03-07 20:27:15]

Description was changed from

==========
MD Settings: Internet: Show details for known networks

This CL adds a show details subpage button for known networks.
This will allow non visible known networks to be configured and
connected to (for hidden networks).

BUG=129289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Show details for known networks

This CL adds a show details subpage button for known networks.
This will allow non visible known networks to be configured and
connected to (for hidden networks).

BUG=129289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2724413002
Cr-Commit-Position: refs/heads/master@{#455199}
Committed:
https://chromium.googlesource.com/chromium/src/+/de034dd8176ef7642646814c4de5...
==========

[commit-bot: I haz the power, 2017-03-07 20:27:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/de034dd8176ef7642646814c4de5...